-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding gsw-xarray #18775
Adding gsw-xarray #18775
Conversation
This reverts commit 1ef6f27.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
It is asked in the checklist, @DocOtak could you comment here that you agree to be maintainer of the recipe (if you agree of course :p) |
I agree and am willing to be listed here. |
Hello @conda-forge/help-python, I checked on the doc but did not found how I should do to create the recipe for a package that uses poetry as package manager. |
Co-authored-by: Daniel Ching <[email protected]>
Hello @conda-forge/help-python, ready for review We still have a qeustion: Is the --use-deprecated=out-of-tree-build necessary? In the pip doc it seems that it will be removed in pip version 22.1 (https://pip.pypa.io/en/latest/topics/local-project-installs/#build-artifacts) |
Yes, this is the current recommendation for packages that use poetry for build until conda-build is patched. I believe that without this arg, poetry will try and create its own build environment which is not what we want / is redundant. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/gsw-xarray:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Thanks for your answer regarding poetry |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).