Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding gsw-xarray #18775

Merged
merged 7 commits into from
May 13, 2022
Merged

Adding gsw-xarray #18775

merged 7 commits into from
May 13, 2022

Conversation

rcaneill
Copy link
Contributor

@rcaneill rcaneill commented Apr 27, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gsw-xarray) and found it was in an excellent condition.

@rcaneill
Copy link
Contributor Author

It is asked in the checklist, @DocOtak could you comment here that you agree to be maintainer of the recipe (if you agree of course :p)

@DocOtak
Copy link

DocOtak commented Apr 27, 2022

I agree and am willing to be listed here.

@rcaneill
Copy link
Contributor Author

Hello @conda-forge/help-python, I checked on the doc but did not found how I should do to create the recipe for a package that uses poetry as package manager.
I guess I shoud add poetry-core>=1.0.0 somewhere? But where?
Thanks for your help!

@rcaneill
Copy link
Contributor Author

rcaneill commented May 9, 2022

Hello @conda-forge/help-python, ready for review

We still have a qeustion: Is the --use-deprecated=out-of-tree-build necessary? In the pip doc it seems that it will be removed in pip version 22.1 (https://pip.pypa.io/en/latest/topics/local-project-installs/#build-artifacts)

@carterbox
Copy link
Member

Yes, this is the current recommendation for packages that use poetry for build until conda-build is patched. I believe that without this arg, poetry will try and create its own build environment which is not what we want / is redundant.

Related: conda-forge/conda-forge.github.io#1540

recipes/gsw-xarray/LICENSE.rst Outdated Show resolved Hide resolved
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gsw-xarray) and found some lint.

Here's what I've got...

For recipes/gsw-xarray:

  • license_file entry is missing, but is required.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gsw-xarray) and found it was in an excellent condition.

@rcaneill rcaneill requested a review from carterbox May 10, 2022 07:10
@rcaneill
Copy link
Contributor Author

Thanks for your answer regarding poetry

@carterbox carterbox merged commit 940b5b1 into conda-forge:main May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants