Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix persistent sending #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Fix persistent sending #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stupidArtnet/StupidArtnet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ def start(self):
self.show()
if not hasattr(self, "running"):
self.running = True
elif self.running:
if self.running:
Copy link
Owner

@cpvalente cpvalente Feb 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: would this code not always evaluate to true since it was set the line before?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If self.running exists and is False (with stop function), it will not be set to True in the previous line.
So I think the condition is necessary to stop the thread.

sleep((1000.0 / self.fps) / 1000.0)
_thread.start_new_thread(self.start, ())

Expand Down