Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ses): dont use native harden #2677

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erights
Copy link
Contributor

@erights erights commented Jan 1, 2025

Was staged on #2675 , but changed to standalone to isolate problems.

Closes: #XXXX
Refs: #XXXX

Description

Old: Differs from #2675 only in that is doesn't use the native hardener if there, and therefore not on XS, because that one does not (yet?) support suppressTrapping.

This is expected to be too expensive for production, so currently this PR is only to see what breaks under CI, and why.

Security Considerations

Does this change introduce new assumptions or dependencies that, if violated, could introduce security vulnerabilities? How does this PR change the boundaries between mutually-suspicious components? What new authorities are introduced by this change, perhaps by new API calls?

Scaling Considerations

Does this change require or encourage significant increase in consumption of CPU cycles, RAM, on-chain storage, message exchanges, or other scarce resources? If so, can that be prevented or mitigated?

Documentation Considerations

Give our docs folks some hints about what needs to be described to downstream users. Backwards compatibility: what happens to existing data or deployments when this code is shipped? Do we need to instruct users to do something to upgrade their saved data? If there is no upgrade path possible, how bad will that be for users?

Testing Considerations

Every PR should of course come with tests of its own functionality. What additional tests are still needed beyond those unit tests? How does this affect CI, other test automation, or the testnet?

Compatibility Considerations

Does this change break any prior usage patterns? Does this change allow usage patterns to evolve?

Upgrade Considerations

What aspects of this PR are relevant to upgrading live production systems, and how should they be addressed?

Include *BREAKING*: in the commit message with migration instructions for any breaking change.

Update NEWS.md for user-facing changes.

Delete guidance from pull request description before merge (including this!)

@erights erights self-assigned this Jan 1, 2025
@erights erights changed the base branch from master to markm-use-no-trapping-shim January 1, 2025 05:19
@erights erights changed the title Markm dont use native harden fix(ses): dont use native harden Jan 1, 2025
@erights erights force-pushed the markm-use-no-trapping-shim branch 7 times, most recently from 60157c5 to 82e1233 Compare January 3, 2025 19:55
@erights erights force-pushed the markm-dont-use-native-harden branch from cf7676f to 528a9c4 Compare January 3, 2025 19:59
@erights erights changed the base branch from markm-use-no-trapping-shim to master January 3, 2025 19:59
@erights erights force-pushed the markm-dont-use-native-harden branch from 528a9c4 to 2907df1 Compare January 3, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant