Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-e2e: Add action tests for challenger and stopping at the game timestamp #13818

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Jan 16, 2025

Description

Action test for #13812 to test it more in the real world and ensure kona matches the behaviour.

Also adds subtests that compare the challenger's trace provider outputs to the test expectations to ensure they match up.

Removed startTimestamp from the test struct as it wasn't used - the agreed prestate is what sets the start timestamp for the transition.

@ajsutton ajsutton requested review from a team as code owners January 16, 2025 20:01
@ajsutton ajsutton requested a review from geoknee January 16, 2025 20:01
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.63%. Comparing base (5f4757c) to head (16bbe60).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13818      +/-   ##
===========================================
- Coverage    46.86%   45.63%   -1.24%     
===========================================
  Files          972      915      -57     
  Lines        80900    76127    -4773     
  Branches       774      774              
===========================================
- Hits         37917    34742    -3175     
+ Misses       40095    38669    -1426     
+ Partials      2888     2716     -172     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests 89.01% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-node/rollup/interop/managed/api.go 92.30% <100.00%> (+15.38%) ⬆️

... and 70 files with indirect coverage changes

@ajsutton ajsutton requested review from a team as code owners January 16, 2025 21:10
@ajsutton ajsutton changed the title op-e2e: Add action test to confirm fault proof program stops at the game timestamp op-e2e: Add action tests for challenger and stopping at the game timestamp Jan 16, 2025
… agreed timestamp is already at the game timestamp
Ensures that it generates super root/transition states that match the test expectations.
Update RootProvider interface to match the actual interface exposed by Supervisor
@ajsutton ajsutton force-pushed the aj/interop-stop-action-test branch from fbb1610 to 16bbe60 Compare January 17, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant