fix: Reduce fuzzer expression depth due to bias run failure #12337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterenescu
requested review from
assignUser and
majetideepak
as code owners
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69674802 |
✅ Deploy Preview for meta-velox canceled.
|
peterenescu
added a commit
to peterenescu/velox
that referenced
this pull request
Feb 14, 2025
…incubator#12337) Summary: Reduce bias run fuzzer depth due to a recent failure caused by array_top_n merge. The error is a result of byte limitation imposed by JVM that C++ doesn't have, which causes fuzzer tests to failure for nested calls. Differential Revision: D69674802
peterenescu
force-pushed
the
export-D69674802
branch
from
8299121 to
cf1b08a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69674802 |
peterenescu
added a commit
to peterenescu/velox
that referenced
this pull request
Feb 14, 2025
…incubator#12337) Summary: Reduce bias run fuzzer depth due to a recent failure caused by array_top_n merge. The error is a result of byte limitation imposed by JVM that C++ doesn't have, which causes fuzzer tests to failure for nested calls. Differential Revision: D69674802
peterenescu
force-pushed
the
export-D69674802
branch
from
cf1b08a to
9dfb14b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69674802 |
peterenescu
added a commit
to peterenescu/velox
that referenced
this pull request
Feb 14, 2025
…incubator#12337) Summary: Reduce bias run fuzzer depth due to a recent failure caused by array_top_n merge. The error is a result of byte limitation imposed by JVM that C++ doesn't have, which causes fuzzer tests to failure for nested calls. Differential Revision: D69674802
peterenescu
force-pushed
the
export-D69674802
branch
from
9dfb14b to
528ed5e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69674802 |
…incubator#12337) Summary: Reduce bias run fuzzer depth due to a recent failure caused by array_top_n merge. The error is a result of byte limitation imposed by JVM that C++ doesn't have, which causes fuzzer tests to failure for nested calls. Differential Revision: D69674802
peterenescu
force-pushed
the
export-D69674802
branch
from
528ed5e to
eba2463
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69674802 |
bikramSingh91
approved these changes
Feb 14, 2025
kgpai
reviewed
Feb 14, 2025
| @@ -992,6 +992,7 @@ jobs: | |||
| --stderrthreshold=2 \ | |||
| --log_dir=/tmp/presto_only_bias_function_fuzzer_repro/logs \ | |||
| --repro_persist_path=/tmp/presto_only_bias_function_fuzzer_repro \ | |||
| --velox_fuzzer_max_level_of_nesting=4 \ | |||
There was a problem hiding this comment.
I think it will be better if we dont change it. The failure found in array_top_n is a good thing and it will only retrigger if array_top_n is modified again. We should aim to find more such bugs.
There was a problem hiding this comment.
One thing to be mindful of is that this will fail the fuzzer and prevent potential correctness issues to be tested, so if we encounter this in the future, we should encourage the author to run this fuzzer with reduced level of nesting in order to surface actual correctness bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Reduce bias run fuzzer depth due to a recent failure caused by array_top_n merge. The error is a result of byte limitation imposed by JVM that C++ doesn't have, which causes fuzzer tests to failure for nested calls.
Differential Revision: D69674802