Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reduce fuzzer expression depth due to bias run failure #12337

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

fix: Reduce fuzzer expression depth due to bias run failure #12337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/scheduled.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,6 +992,7 @@ jobs:
--stderrthreshold=2 \
--log_dir=/tmp/presto_only_bias_function_fuzzer_repro/logs \
--repro_persist_path=/tmp/presto_only_bias_function_fuzzer_repro \
--velox_fuzzer_max_level_of_nesting=4 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be better if we dont change it. The failure found in array_top_n is a good thing and it will only retrigger if array_top_n is modified again. We should aim to find more such bugs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to be mindful of is that this will fail the fuzzer and prevent potential correctness issues to be tested, so if we encounter this in the future, we should encourage the author to run this fuzzer with reduced level of nesting in order to surface actual correctness bugs

&& echo -e "\n\nPresto Fuzzer run finished successfully."
- name: Archive Presto only-bias-function expression fuzzer production artifacts
if: ${{ !cancelled() }}
Expand Down