-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallelize tests by filename #135
Parallelize tests by filename #135
Conversation
Signed-off-by: ryanohnemus <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you resolve the linting problems?
Signed-off-by: ryanohnemus <[email protected]>
Signed-off-by: ryanohnemus <[email protected]>
6874330
to
0cb622f
Compare
@patrick-stephens, sorry it was a busy week so it took me a bit to get back to this. I just got the lints fixed and I added a little documentation. Please take another look when you get a chance, thank you! |
Signed-off-by: ryanohnemus <[email protected]>
@@ -68,8 +62,8 @@ teardown() { | |||
|
|||
function set_fluent_bit_pod_name() { | |||
try "at most 30 times every 2s " \ | |||
"to find 1 pods named 'fluentbit-ci-tests' " \ | |||
"with 'status' being 'Running'" | |||
"to find 1 pods named 'fluent-bit' " \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should parameterise this to simplify?
Signed-off-by: ryanohnemus <[email protected]>
This makes a few changes to some current expectations that allows us to run tests in parallel and can speed up test runs from around 11 minutes down to 4 minutes (which could be trimmed down even further if the chunked-rollover test is re-worked and there isn't a 3 minute sleep within it).
Changes:
TEST_NAMESPACE
variable in theirsetup_file()
. We no longer requireTEST_NAMESPACE
being set before the test is run for this reason.fullnameOverrides
are used within the helm installs so that daemonsets or clusterroles being set up by the helm chart do not conflict when they run in parallel. This also means for tests that use multiple helms (like elasticsearch), I removed passing the extra templated helm file options passed to them as usingfullnameOverrides
conflicts and causes elasticsearch to take on the same name we're giving fluent-bit.run-tests.sh
tests will be required to run in sequential order (as they do today), but the fullnameOverride logic above still applies.create_helm_extra_values_file
was also created withintest-helpers.bash
to remove some of the copy code.