Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable user list dismissal if a current user hasn't been selected #3814

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

bbirman
Copy link
Member

@bbirman bbirman commented Jan 24, 2025

For #3690

Testing enabled vs disabled:

Screenshot 2025-01-23 at 5 57 00 PM Screenshot 2025-01-23 at 5 57 08 PM

Copy link

1 Warning
⚠️ Static Analysis found an issue with one or more files you modified. Please fix the issue(s).

Clang Static Analysis Issues

File Type Category Description Line Col
SFDefaultUserManagementListViewController Unlocalizable string Localizability Issue (Apple) User-facing text should use localized string macro 61 25
SFDefaultUserManagementListViewController Unlocalizable string Localizability Issue (Apple) User-facing text should use localized string macro 63 36
SFDefaultUserManagementListViewController Unlocalizable string Localizability Issue (Apple) User-facing text should use localized string macro 123 30
SFDefaultUserManagementListViewController Unlocalizable string Localizability Issue (Apple) User-facing text should use localized string macro 125 30

Generated by 🚫 Danger

Copy link
Contributor

@brandonpage brandonpage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I'll be sure to remember this when doing the new Android screen next week.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.89%. Comparing base (ca119e9) to head (1af320f).
Report is 16 commits behind head on dev.

Files with missing lines Patch % Lines
...ollers/SFDefaultUserManagementListViewController.m 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3814      +/-   ##
==========================================
+ Coverage   61.67%   61.89%   +0.21%     
==========================================
  Files         233      233              
  Lines       21630    21699      +69     
==========================================
+ Hits        13340    13430      +90     
+ Misses       8290     8269      -21     
Components Coverage Δ
Analytics 81.88% <90.90%> (-2.22%) ⬇️
Common 68.87% <ø> (ø)
Core 50.47% <40.00%> (+0.40%) ⬆️
SmartStore 73.70% <ø> (ø)
MobileSync 87.58% <ø> (ø)
Files with missing lines Coverage Δ
...ollers/SFDefaultUserManagementListViewController.m 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

@bbirman bbirman merged commit ef880f7 into forcedotcom:dev Jan 24, 2025
7 of 8 checks passed
@bbirman bbirman deleted the user-list branch January 24, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants