Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable user list dismissal if a current user hasn't been selected #3814

Merged
merged 1 commit into from
Jan 24, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Disable user list dismissal if a current user hasn't been selected
bbirman committed Jan 24, 2025
commit 1af320fdab9a113c4ffa4aabe9a50fe81d01de61
Original file line number Diff line number Diff line change
@@ -74,6 +74,12 @@ - (void)viewWillAppear:(BOOL)animated
// the current user, if present, will be separated from the other users in the table view.
_userAccountList = [self accountListMinusCurrentUser:[SFUserAccountManager sharedInstance].allUserAccounts];
_hasCurrentUser = ([SFUserAccountManager sharedInstance].currentUser != nil);

// If there there's no current user, don't let the user cancel or dismiss the window before
// selecting an existing user or logging into a new one
self.navigationItem.leftBarButtonItem.enabled = _hasCurrentUser;
self.modalInPresentation = !_hasCurrentUser;

[self.tableView reloadData];
}


Unchanged files with check annotations Beta

self.layer.borderColor = [UIColor salesforceSystemBackgroundColor].CGColor;
}
- (void)traitCollectionDidChange:(UITraitCollection *)previousTraitCollection {

Check warning on line 95 in libs/SalesforceSDKCore/SalesforceSDKCore/Classes/IDP/SFSDKUITableViewCell.m

GitHub Actions / ios-pr (SalesforceSDKCore) / test-ios

implementing deprecated method [-Wdeprecated-implementations]
[super traitCollectionDidChange:previousTraitCollection];

Check warning on line 96 in libs/SalesforceSDKCore/SalesforceSDKCore/Classes/IDP/SFSDKUITableViewCell.m

GitHub Actions / ios-pr (SalesforceSDKCore) / test-ios

'traitCollectionDidChange:' is deprecated: first deprecated in iOS 17.0 - Use the trait change registration APIs declared in the UITraitChangeObservable protocol [-Wdeprecated-declarations]
if ([self.traitCollection hasDifferentColorAppearanceComparedToTraitCollection:previousTraitCollection]) {
[self updateLayerColor];
}
XCTAssertNotNil(userOut.idData, @"couldn't unarchive idData");
XCTAssertEqualObjects(userIn.customData, userOut.customData, @"customData mismatch");
XCTAssertEqualObjects(userIn.accessScopes, userOut.accessScopes, @"accessScopes mismatch");

Check failure on line 663 in libs/SalesforceSDKCore/SalesforceSDKCoreTests/SFUserAccountManagerTests.m

GitHub Actions / ios-pr (SalesforceSDKCore) / test-ios

testUserAccountEncoding, ((userIn.accessScopes) equal to (userOut.accessScopes)) failed: ("***(
XCTAssertEqual(userIn.accessRestrictions, userOut.accessRestrictions, @"accessRestrictions mismatch");
}
if (attributes[kSFSDKEventBuilderHelperEndTime]) {
builder.endTime = [((NSNumber*) attributes[kSFSDKEventBuilderHelperEndTime]) integerValue];
}
builder.page = @{ @"context" : className };

Check failure on line 57 in libs/SalesforceSDKCore/SalesforceSDKCore/Classes/Analytics/SFSDKEventBuilderHelper.m

GitHub Actions / ios-pr (SalesforceSDKCore) / test-ios

testAssertionForUnauthenticatedClient, *** -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[0] (NSInvalidArgumentException)
if (attributes) {
builder.attributes = attributes;
}