-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check for activeElement before calling blur() on it #11260
Conversation
Mh, we still have the focus / blur issue on IE. Didn't we already fix this? On IE11 is is body. |
See #11275 |
Tests pass with |
Hm, even with the change Android 4.4 fails: |
I guess their devices are too slow. |
@DanielRuf I already tried on your branch the changes with this PR #11333 and it works. There's just the browserstack runner bug. |
What about the linked lines? Firefox and Android 4.4? |
Well, then I'll wait and see what happens after the merge or rebase. |
@DanielRuf They still happen time to time. I was only talking about the fails due to timeouts. |
I made some tests and this PR (with a9334ad) introduce the following error:
See https://www.travis-ci.org/ncoden/foundation-sites/jobs/392158100 With |
Initially we needed this because of:
But I never seen this error in our tests. So unless you can reproduce it on browserstack and send me a link I think we can close this PR. |
Racing conditions and tests for debouncing were resolved in others PRs. (#11279) |
Description
Replaces #11214
Motivation and Context
Fixes the unit tests in IE11 on Windows 10.
Types of changes
functionality to change)
Checklist (all required):
develop
orsupport/*
).