test: give time to IE to render elements before testing focus #11275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For all the following tests testing the currently focused elements, IE 9/10/11 may not focus the tested element because is is still rendering. To prevent this, we wait after the component initialization. Fixing this IE behavior in components would require to delay the focus for all browsers then trigger a "ready" event. See https://stackoverflow.com/a/2600261/4317384 See https://stackoverflow.com/a/36032615/4317384
This was referenced May 16, 2018
|
poke @DanielRuf |
DanielRuf
approved these changes
May 18, 2018
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Jun 16, 2018
…test-focus for v6.5.0 1c36420 test: give time to IE to render elements before testing focus Signed-off-by: Nicolas Coden <[email protected]>
This was referenced Jun 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Internet Explorer 9/10/11 may not focus the tested element because is is still rendering. To prevent this, we wait after the component initialization.
Note: I tested it a lot and after we
.focus()the Dropdown Menu sublink (the sublink exists), IE focus the body instead, as if the sublink could not receive focus. There were no others tests running, all others.focus()in Foundation were disabled. This is a really weird bug and the "not rendered bug" scenario seems the more plausible.Fixing this IE behavior in components would require to delay the focus for all browsers then trigger a "ready" event. This will be considered for v6.6 because this may introduce a breaking change.
Changes
References
Types of changes
functionality to change)
Checklist (all required):
developorsupport/*).