PHP 8.4: E_STRICT constant deprecated #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is related to this topic: https://tracker.moodle.org/browse/MDL-83334 |
|
This looks good, but tbh I'd prefer a check with uses |
|
I will add a comment. What about the following line? //if ($errCode != E_NOTICE && $errCode != E_WARNING && $errCode != E_USER_NOTICE && $errCode != E_USER_WARNING)Do we need this? Can this go? I did not find any information on its history. |
From PHP 8.4 the E_STRICT constant has been deprecated and will emit deprecation notices. PHP core and core extensions since PHP 8.0 and later do not emit E_STRICT notices at all. On PHP 7 series before PHP 7.4, some functions conditionally emit E_STRICT notices. For details see: https://php.watch/versions/8.4/E_STRICT-deprecated Signed-off-by: Daniel Ziegenberg <[email protected]>
Signed-off-by: Daniel Ziegenberg <[email protected]>
ziegenberg
force-pushed
the
e-strict-deprecation
branch
from
4752a0a to
ba1220f
Compare
|
I removed the additional but unused conditional in an extra commit. You may drop it or keep it as you see fit. I also amended the commit message providing a bit more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From PHP 8.4 the E_STRICT constant has been deprecated and will emit deprecation notices.
PHP core and core extensions since PHP 8.0 and later do not emit E_STRICT notices at all. It is safe to assume that any PHP applications that run on PHP 8.0 and later will never encounter E_STRICT notices, and error reporting and handling can be safely updated to ignore E_STRICT notices.
For details see: https://php.watch/versions/8.4/E_STRICT-deprecated