Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4: E_STRICT constant deprecated #125

Merged
merged 2 commits into from
Jan 17, 2025
Merged

PHP 8.4: E_STRICT constant deprecated #125

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd98c67
PHP 8.4: E_STRICT constant deprecated
ziegenberg Jan 17, 2025
ba1220f
remove unused conditional in error handler
ziegenberg Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Server.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1416,9 +1416,13 @@ public static function _xmlrpcs_errorHandler($errCode, $errString, $filename = n
return;
}

//if ($errCode != E_NOTICE && $errCode != E_WARNING && $errCode != E_USER_NOTICE && $errCode != E_USER_WARNING)
if ($errCode != E_STRICT) {
// From PHP 8.4 the E_STRICT constant has been deprecated and will emit deprecation notices.
// PHP core and core extensions since PHP 8.0 and later do not emit E_STRICT notices at all.
// On PHP 7 series before PHP 7.4, some functions conditionally emit E_STRICT notices.
if (PHP_VERSION_ID >= 70400) {
static::error_occurred($errString);
} elseif ($errCode != E_STRICT) {
static::error_occurred($errString);
}

// Try to avoid as much as possible disruption to the previous error handling mechanism in place
Expand Down