Implement default auto-configuration of plugin from service account tokens when running in K8S #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that mounted into the pod - fixes #44 - fixes #328 (by removing the need for use of such approaches) By default the plugin now uses the Fabric Kubernetes Client auto-configuration support to configure itself when the values are un-set from the Plugin Settings UI. This will be the best defaults for almost all users. If any of Cluster URL / Namespace / Security Token / CA Cert data are overridden by the user, they will be used instead. If the pod does not have service account values available it will fail without values being set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change cluster URL and security tokens to be optional, defaulting to those mounted into the pod.
By default the plugin now uses the Fabric Kubernetes Client auto-configuration support to configure
itself when the values are un-set from the Plugin Settings UI. This will be the best defaults for
almost all users. If any of Cluster URL / Namespace / Security Token / CA Cert data are overridden
by the user, they will be used instead. If the pod does not have service account values available
it will fail without values being set.