-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add libfaust with llvm github action #862
Conversation
build-macos is for x86_64 only, it is possible to build also the ARM version? |
Unfortunately not yet on GitHub actions. Maybe one day they'll have ARM runner images. If it were possible, then there would be a new entry in the macos matrix like this:
|
It seems https://github.com/agraef/pd-faustgen is able to do it, see; |
No more bloat in the ubuntu zip. It's just
So I think we're good, except still no macos arm automation. |
Oh I'll look into what you said about pd-faustgen. |
For macos and ubuntu, it looks like libsndfile.a/so are already in the faust repo. Are those suitable for building with libfaust? Do they enable mp3/flac/ogg etc? The current obstacle is linking building/linking against arm64 versions of the dependencies to libsndfile. I'm trying brew on the GitHub action. |
libsndfile.a/so are not directly need in libfaust, but in architectures files that implement the |
What do you think about including it anyway? If yes, should we build libsndfile as a dynamic or static library? It would save me some duplicate work in DawDreamer/TD-Faust, and I imagine other users who link against libfaust will also want to link against sndfile often. |
Let's leave out sndfile. I'm going to have my arm64 mac this weekend and I'll prepare two llvm builds the same way pd-faustgen did. |
Closing in favor of #864 |
This sets up a new workflow that builds libfaust dynamic libraries with LLVM on macos, ubuntu, and windows. The workflow only launches via a button on the GitHub actions page. The build results in artifacts which can be downloaded at the bottom of the actions page:
https://github.com/DBraun/faust/actions/runs/4311010847
Windows artifact contains:
macos artifact contains:
Note that the Ubuntu zip has duplicate files. To keep it smaller, I need to decide which of the three files to keep:
The action/upload-artifact doesn't work well with symbolic links (actions/upload-artifact#93)
I ended up just uploading the entire build/lib folder, and I think that hardened the symbolic links into duplicate files, bloating the ubuntu zip.