chore(deps): bump the aws-sdk group with 2 updates #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
akash1810
force-pushed
the
dependabot/npm_and_yarn/aws-sdk-5bb87a9087
branch
2 times, most recently
from
771c637 to
9d7cf76
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/aws-sdk-5bb87a9087
branch
2 times, most recently
from
a878c1e to
ee17082
Compare
akash1810
force-pushed
the
dependabot/npm_and_yarn/aws-sdk-5bb87a9087
branch
from
ee17082 to
231178b
Compare
akash1810
added a commit
to guardian/cdk-playground
that referenced
this pull request
Dec 31, 2024
akash1810
force-pushed
the
dependabot/npm_and_yarn/aws-sdk-5bb87a9087
branch
from
231178b to
cde373c
Compare
akash1810
added a commit
to guardian/cdk-playground
that referenced
this pull request
Dec 31, 2024
akash1810
force-pushed
the
dependabot/npm_and_yarn/aws-sdk-5bb87a9087
branch
from
a056050 to
467cc54
Compare
akash1810
added a commit
to guardian/cdk-playground
that referenced
this pull request
Dec 31, 2024
akash1810
reviewed
Dec 31, 2024
Comment on lines
+125
to
+127
| requestHandler: { | ||
| requestTimeout: 10 * 1000, // 10 seconds | ||
| }, |
There was a problem hiding this comment.
This value is fairly arbitrary; unsure how to be more scientific about it. I tested with 5 seconds and that wasn't enough...
See also aws/aws-sdk-js-v3#6763.
akash1810
reviewed
Dec 31, 2024
| }, | ||
|
|
||
| // Enable AWS SDK logging if the action is run in debug mode | ||
| ...(core.isDebug() && { logger: { ...console } }), |
There was a problem hiding this comment.
Bumps the aws-sdk group with 2 updates: [@aws-sdk/client-s3](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-s3) and [@aws-sdk/credential-providers](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/packages/credential-providers). Updates `@aws-sdk/client-s3` from 3.703.0 to 3.717.0 - [Release notes](https://github.com/aws/aws-sdk-js-v3/releases) - [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-s3/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.717.0/clients/client-s3) Updates `@aws-sdk/credential-providers` from 3.699.0 to 3.716.0 - [Release notes](https://github.com/aws/aws-sdk-js-v3/releases) - [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/packages/credential-providers/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.716.0/packages/credential-providers) --- updated-dependencies: - dependency-name: "@aws-sdk/client-s3" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk - dependency-name: "@aws-sdk/credential-providers" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk ... Signed-off-by: dependabot[bot] <[email protected]>
Since updating `@aws-sdk/client-s3` to v3.717.0 we've seen an increase of timeouts: > RequestTimeout: Your socket connection to the server was not read from or written to within the timeout period. Idle connections will be closed. See https://docs.aws.amazon.com/sdk-for-javascript/v3/developer-guide/node-configuring-maxsockets.html
akash1810
force-pushed
the
dependabot/npm_and_yarn/aws-sdk-5bb87a9087
branch
from
467cc54 to
9b396d6
Compare
akash1810
added a commit
to guardian/dotcom-rendering
that referenced
this pull request
Jan 3, 2025
adamnfish
approved these changes
Jan 3, 2025
akash1810
added a commit
that referenced
this pull request
Jan 7, 2025
Since the upgrade, we've experienced `RequestTimeout` errors in the build of a `guardian/dotcom-rendering`. We patched this in https://github.com/guardian/actions-riff-raff/releases/tag/v4.1.4. Today, we started seeing `guardian/ophan` experience the same issues. This means the randomly chosen 10 second timeout applied in #191 doesn't work for all cases. This change "reverts" the `@aws-sdk/client-s3` and `@aws-sdk/credential-providers` libraries back to known working versions. Note: it isn't a revert in the git sense as the changes are interleaved with others. Additionally, we're now pinning the version number, whereas previously it was ranged.
akash1810
added a commit
that referenced
this pull request
Jan 7, 2025
Since the upgrade, we've experienced `RequestTimeout` errors in the build of a `guardian/dotcom-rendering`. We patched this in https://github.com/guardian/actions-riff-raff/releases/tag/v4.1.4. Today, we started seeing `guardian/ophan` experience the same issues. This means the randomly chosen 10 second timeout applied in #191 doesn't work for all cases. This change "reverts" the `@aws-sdk/client-s3` and `@aws-sdk/credential-providers` libraries back to known working versions. Note: it isn't a revert in the git sense as the changes are interleaved with others. Additionally, we're now pinning the version number, whereas previously it was ranged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the aws-sdk group with 2 updates: @aws-sdk/client-s3 and @aws-sdk/credential-providers.
Updates
@aws-sdk/client-s3from 3.703.0 to 3.717.0Release notes
Sourced from
@aws-sdk/client-s3's releases.... (truncated)
Changelog
Sourced from
@aws-sdk/client-s3's changelog.... (truncated)
Commits
21a7703Publish v3.717.03317a92test: move flexible checksums integration tests (#6752)d032e54Publish v3.716.08af7a02chore(codegen): update for operationContextParams fix (#6751)0ce31bdPublish v3.715.0a116e07Publish v3.714.0afd9eeafeat(clients): profile setting for clients (#6728)b9b146cchore(middleware-flexible-checksums): use object for requestAlgorithmMember (...c2acba2Publish v3.713.0041a906Publish v3.712.0Updates
@aws-sdk/credential-providersfrom 3.699.0 to 3.716.0Release notes
Sourced from
@aws-sdk/credential-providers's releases.... (truncated)
Changelog
Sourced from
@aws-sdk/credential-providers's changelog.Commits
d032e54Publish v3.716.00ce31bdPublish v3.715.07fee20ddocs(credential-providers): fix link casing (#6746)a116e07Publish v3.714.00e65e09docs(clients): document client-level profile configuration (#6737)c2acba2Publish v3.713.0a65995ffeat(credential-providers): make credential providers aware of caller client ...041a906Publish v3.712.0fec23bePublish v3.709.0c685950chore(codegen): update clients for String dispatch fix (#6721)Note
This change also explicitly configures
requestTimeoutof the S3 client as we've seen an increase inRequestTimeouterrors in@aws-sdk/client-s3 v3.717.0.These changes have been tested in guardian/cdk-playground#604 and guardian/dotcom-rendering#13065.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions