Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Galleries Rendering In DCAR #27556

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

JamieB-gu
Copy link
Contributor

Prevent galleries ever rendering in DCAR while we're working on them. This can be reverted or updated when we're ready to release them, most likely with a feature switch as described in #27553

Prevent galleries ever rendering in DCAR while we're working on them. This can be reverted or updated when we're ready to release them.
@JamieB-gu JamieB-gu requested a review from a team as a code owner October 24, 2024 12:05
@JamieB-gu JamieB-gu linked an issue Oct 24, 2024 that may be closed by this pull request
@domlander
Copy link
Contributor

I'm not sure why this PR is needed? It looks like Galleries will only render on DCR if they're forced to render on DCR, which I assume means there is ?dcr in the url.

@JamieB-gu JamieB-gu merged commit 92848d6 into main Oct 28, 2024
6 checks passed
@JamieB-gu JamieB-gu deleted the prevent-galleries-rendering-in-dcar branch October 28, 2024 12:38
@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD, ADMIN-PROD (merged by @JamieB-gu 48 minutes and 36 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent Galleries Rendering In DCAR
3 participants