make transparency of crop gutters configurable via a slider #4341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrichards
force-pushed
the
transparency-slider-on-crop-gutters
branch
from
407a700 to
46584c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4331 added crop gutters under certain scenarios, and we've since been testing with a subset of users (see #4336) and have received the following feedback...
The stripes are white, but with
mix-blend-mode: differencewhich attempts to invert the colour below, however depending on the colour/darkness below this can appear too 'opaque', so this PR attempts to make that more flexible per-crop by introducing a slider in explainer message (this is intentionally reset between crops, with a starting value of 0.8 opacity, i.e. 80% transparency).