Publish Feast/Apple sub notifications to SQS #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaelGNM
reviewed
Mar 13, 2024
tjmw
approved these changes
Mar 14, 2024
tomwadeson
force-pushed
the
tew/feast-subscription-event-queue
branch
from
b48feec to
35607c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR extends the Feast/Apple webhook handler to publish subscription events to a new SQS queue.
How to test
Post a dummy webhook payload to the endpoint (use the example from the unit test) and observe that the associated receipt is published to the queue.
Observed in CODE:
How can we measure success?
Have we considered potential risks?
Images
Accessibility