Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable DeterministicThrottleTest.throttlesWithinPermissibleTolerance() #17412

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

MiroslavGatsanoga
Copy link
Collaborator

@MiroslavGatsanoga MiroslavGatsanoga commented Jan 16, 2025

Description:

Enable DeterministicThrottleTest.throttlesWithinPermissibleTolerance() which was previously flaky.

Related issue(s):

#13667

Notes for reviewer:

Test seems to be passing now, so we can enable it.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Miroslav Gatsanoga <[email protected]>
@MiroslavGatsanoga MiroslavGatsanoga added this to the v0.59 milestone Jan 16, 2025
@MiroslavGatsanoga MiroslavGatsanoga self-assigned this Jan 16, 2025
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Copy link

codacy-production bot commented Jan 16, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8c87f5e) 98537 71821 72.89%
Head commit (55b8235) 98537 (+0) 71819 (-2) 72.89% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17412) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.93%. Comparing base (8c87f5e) to head (55b8235).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17412      +/-   ##
============================================
- Coverage     68.94%   68.93%   -0.01%     
+ Complexity    22855    22854       -1     
============================================
  Files          2630     2630              
  Lines         98754    98754              
  Branches      10252    10252              
============================================
- Hits          68083    68080       -3     
- Misses        26781    26783       +2     
- Partials       3890     3891       +1     

see 1 file with indirect coverage changes

Impacted file tree graph

@MiroslavGatsanoga MiroslavGatsanoga modified the milestones: v0.59, v0.60 Jan 30, 2025
@MiroslavGatsanoga MiroslavGatsanoga changed the title fix: stabilize DeterministicThrottleTest.throttlesWithinPermissibleTolerance() test: enable DeterministicThrottleTest.throttlesWithinPermissibleTolerance() Jan 30, 2025
@MiroslavGatsanoga MiroslavGatsanoga marked this pull request as ready for review January 30, 2025 16:28
@MiroslavGatsanoga MiroslavGatsanoga requested a review from a team as a code owner January 30, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant