-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: enable DeterministicThrottleTest.throttlesWithinPermissibleTolerance() #17412
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17412 +/- ##
============================================
- Coverage 68.94% 68.93% -0.01%
+ Complexity 22855 22854 -1
============================================
Files 2630 2630
Lines 98754 98754
Branches 10252 10252
============================================
- Hits 68083 68080 -3
- Misses 26781 26783 +2
- Partials 3890 3891 +1 |
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Description:
Enable
DeterministicThrottleTest.throttlesWithinPermissibleTolerance()
which was previously flaky.Related issue(s):
#13667
Notes for reviewer:
Test seems to be passing now, so we can enable it.
Checklist