Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable DeterministicThrottleTest.throttlesWithinPermissibleTolerance() #17412

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

test: enable DeterministicThrottleTest.throttlesWithinPermissibleTolerance() #17412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0b4c9f1
chore: reproduce failure
MiroslavGatsanoga Jan 16, 2025
834267c
chore: spotless
MiroslavGatsanoga Jan 16, 2025
ca03f38
chore: reproduce failure
MiroslavGatsanoga Jan 16, 2025
5702d00
chore: revert randomization
MiroslavGatsanoga Jan 30, 2025
55b8235
Merge branch 'main' into 13667-stabilize-flaky-test
MiroslavGatsanoga Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../src/test/java/com/hedera/node/app/hapi/utils/throttles/ConcurrentThrottleTestHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2021-2024 Hedera Hashgraph, LLC
* Copyright (C) 2021-2025 Hedera Hashgraph, LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
4 changes: 1 addition & 3 deletions ...ils/src/test/java/com/hedera/node/app/hapi/utils/throttles/DeterministicThrottleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2021-2024 Hedera Hashgraph, LLC
* Copyright (C) 2021-2025 Hedera Hashgraph, LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -34,7 +34,6 @@
import com.hedera.hapi.node.state.throttles.ThrottleUsageSnapshot;
import edu.umd.cs.findbugs.annotations.NonNull;
import java.time.Instant;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

class DeterministicThrottleTest {
Expand Down Expand Up @@ -146,7 +145,6 @@ void canGetInstantaneousPercentUsed() {
}

@Test
@Disabled("Test is flaky. See https://github.com/hashgraph/hedera-services/issues/13667")
void throttlesWithinPermissibleTolerance() throws InterruptedException {
final long mtps = 123_456L;
final var subject = DeterministicThrottle.withMtps(mtps);
Expand Down