Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the same automatical xml formatting for at least eclipse #1021

Closed
dr0i opened this issue Sep 13, 2019 · 5 comments
Closed

Ensure the same automatical xml formatting for at least eclipse #1021

dr0i opened this issue Sep 13, 2019 · 5 comments
Assignees
Labels

Comments

@dr0i
Copy link
Member

dr0i commented Sep 13, 2019

The howto of formatting of the xml is still a think to do.
As a starter, shipping an xml-formatter for only one IDE, eclipse, should be doable.

@fsteeg
Copy link
Member

fsteeg commented Sep 13, 2019

I think the automation was the problem here, right? You can always manually set up the same options in the XML > XML Files > Editor preferences.

@dr0i
Copy link
Member Author

dr0i commented Sep 13, 2019

At least shipping this preferences to ensure all are using the same formatting configs if manually formatting xml. Then, eclipse can be configured to "automatically format when saving".
Identatation size should be 1.
There are other setting like line width: 121 atm and "insert whitespace before closing tags" etc.
In metafacture-core there is also a problem with formatting, also in the code, so this would be a starter. Just opened metafacture/metafacture-core#307.

@dr0i
Copy link
Member Author

dr0i commented Sep 6, 2021

We should go like metafacture, using .editorconfig. See metafacture/metafacture-core#388.

@dr0i dr0i self-assigned this Sep 6, 2021
@TobiasNx
Copy link
Contributor

TobiasNx commented Oct 4, 2022

@dr0i still relevant?

@dr0i
Copy link
Member Author

dr0i commented Oct 6, 2022

Yes, java source code is missing, also xml I think.
As I am the only one who is working with these files it doesn't matter that much. So I am gonna closing this for now.
You started with 3b71911, which is good, and we could enhance this later.

@dr0i dr0i closed this as completed Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants