Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language to ExampleOfWork (#1823) #1968

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Conversation

maipet
Copy link
Contributor

@maipet maipet commented Feb 15, 2024

Resolves #1823

@maipet maipet requested review from acka47 and dr0i February 15, 2024 06:24
Copy link
Contributor

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See other comments on dobule language URIs and question re. Romani in example.

"type" : [ "Work" ]
"type" : [ "Work" ],
"language" : [ {
"id" : "http://id.loc.gov/vocabulary/iso639-2/http://id.loc.gov/vocabulary/iso639-2/lat",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a problem with the language URI being repeated.

"id" : "http://id.loc.gov/vocabulary/iso639-2/http://id.loc.gov/vocabulary/iso639-2/lat",
"label" : "Latein"
}, {
"id" : "http://id.loc.gov/vocabulary/iso639-2/http://id.loc.gov/vocabulary/iso639-2/rom",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well double language URI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, where does the Romani come from? I have problems finding it in the MARC version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sry, I messed up my testfile - "romani" was a manually created test case, as I didn't have a "real" MARC example. I forgot to create a new json after I reset the MARC file to the original state
The double URI-prefix is now also correct.

Insert "prepend" into unless-clause
Copy link
Contributor

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's fine from my side now. However, I am not the right person to review the Metafacture fix implementation. @dr0i, can you do this?

@acka47
Copy link
Contributor

acka47 commented Feb 15, 2024

I forgot one thing. In one issue comment it reads:

If we indexed the new field exampleOfWork.language.id, @hauschke could query like this: language.id:"http://id.loc.gov/vocabulary/iso639-2/ger" AND exampleOfWork.language.id:http://id.loc.gov/vocabulary/iso639-2/eng

So, we should also adjust the index config accordingly in this PR. @dr0i , can you do this?

@dr0i dr0i merged commit 42806d5 into master Feb 19, 2024
1 check passed
@dr0i
Copy link
Member

dr0i commented Feb 19, 2024

Thx! Will be deployed next Monday.

@dr0i dr0i deleted the 1823-AddLanguageOfOriginal branch February 19, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add language information for original work
4 participants