-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language to ExampleOfWork (#1823) #1968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See other comments on dobule language URIs and question re. Romani in example.
"type" : [ "Work" ] | ||
"type" : [ "Work" ], | ||
"language" : [ { | ||
"id" : "http://id.loc.gov/vocabulary/iso639-2/http://id.loc.gov/vocabulary/iso639-2/lat", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a problem with the language URI being repeated.
"id" : "http://id.loc.gov/vocabulary/iso639-2/http://id.loc.gov/vocabulary/iso639-2/lat", | ||
"label" : "Latein" | ||
}, { | ||
"id" : "http://id.loc.gov/vocabulary/iso639-2/http://id.loc.gov/vocabulary/iso639-2/rom", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as well double language URI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, where does the Romani come from? I have problems finding it in the MARC version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sry, I messed up my testfile - "romani" was a manually created test case, as I didn't have a "real" MARC example. I forgot to create a new json after I reset the MARC file to the original state
The double URI-prefix is now also correct.
Insert "prepend" into unless-clause
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it's fine from my side now. However, I am not the right person to review the Metafacture fix implementation. @dr0i, can you do this?
I forgot one thing. In one issue comment it reads:
So, we should also adjust the index config accordingly in this PR. @dr0i , can you do this? |
Thx! Will be deployed next Monday. |
Resolves #1823