Final adjustments and corrections for schema validation #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acka47
requested changes
Aug 9, 2024
| @@ -296,8 +296,10 @@ do list(path:"084??", "var":"$i") | |||
| if any_match("$j","\\d{3}(\\.\\d{1,3})?|[BKS]") | |||
| if any_equal("$i.q","DE-600") | |||
| add_field("subject[].$last.source.label","DDC-Sachgruppen der ZDB") | |||
| add_field("subject[].$last.source.id","https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf") | |||
There was a problem hiding this comment.
Interesting choice of id for this source. While I like the pragmatism, this sets a new precedent linking to the description of a controlled vocabulary in a documentation PDF. As I have no better idea, I guess we can leave it for now.
There was a problem hiding this comment.
On the other hand, we should probably better leave out the id field and add the documentation link in another field, e.g. seeAlso.
There was a problem hiding this comment.
I already had a bad feeling a while ago about id: #1848 (comment)
There was a problem hiding this comment.
But we decided off board to go on for a lack of a better id.
acka47
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1340
This PR: