Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final adjustments and corrections for schema validation #2049

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Final adjustments and corrections for schema validation #2049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9104237
Add source.id for DDC-Sachgruppen der ZDB
TobiasNx Aug 8, 2024
f1ef5fe
Adjust skosConcept schema to catch notation systems too and to enforc…
TobiasNx Aug 8, 2024
cdaaf11
Fix formal error in type schema
TobiasNx Aug 8, 2024
cdd4d4c
Add MusicalRecording as possible type
TobiasNx Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/resources/alma/fix/subjects.fix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,8 +296,10 @@ do list(path:"084??", "var":"$i")
if any_match("$j","\\d{3}(\\.\\d{1,3})?|[BKS]")
if any_equal("$i.q","DE-600")
add_field("subject[].$last.source.label","DDC-Sachgruppen der ZDB")
add_field("subject[].$last.source.id","https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting choice of id for this source. While I like the pragmatism, this sets a new precedent linking to the description of a controlled vocabulary in a documentation PDF. As I have no better idea, I guess we can leave it for now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the other hand, we should probably better leave out the id field and add the documentation link in another field, e.g. seeAlso.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already had a bad feeling a while ago about id: #1848 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we decided off board to go on for a lack of a better id.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then let's go. +1

elsif any_equal("$i.2","zdbs")
add_field("subject[].$last.source.label","DDC-Sachgruppen der ZDB")
add_field("subject[].$last.source.id","https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf")
else
add_field("subject[].$last.source.label","Sachgruppen der DNB")
add_field("subject[].$last.source.id","https://bartoc.org/en/node/20049")
Expand Down
6 changes: 4 additions & 2 deletions src/test/resources/alma-fix/990053976760206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,14 +192,16 @@
"notation" : "370",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Erziehung, Schul- und Bildungswesen"
}, {
"notation" : "530",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Physik"
}, {
Expand Down
3 changes: 2 additions & 1 deletion src/test/resources/alma-fix/990054089950206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,8 @@
"notation" : "790",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Freizeitgestaltung, Darstellende Kunst"
}, {
Expand Down
3 changes: 2 additions & 1 deletion src/test/resources/alma-fix/990054215550206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,8 @@
"notation" : "310",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Allgemeine Statistiken"
}, {
Expand Down
3 changes: 2 additions & 1 deletion src/test/resources/alma-fix/990054301770206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,8 @@
"notation" : "910",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Geografie, Reisen"
}, {
Expand Down
6 changes: 4 additions & 2 deletions src/test/resources/alma-fix/990054345550206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,14 +188,16 @@
"notation" : "914.3",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Geografie, Reisen (Deutschland)"
}, {
"notation" : "943",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Geschichte Deutschlands"
}, {
Expand Down
3 changes: 2 additions & 1 deletion src/test/resources/alma-fix/990055981810206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,8 @@
"notation" : "060",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Organisationen, Museumswissenschaft"
}, {
Expand Down
9 changes: 6 additions & 3 deletions src/test/resources/alma-fix/990103770440206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,8 @@
"notation" : "070",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Nachrichtenmedien, Journalismus, Verlagswesen"
}, {
Expand All @@ -167,7 +168,8 @@
"notation" : "914.3",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Geografie, Reisen (Deutschland)"
}, {
Expand All @@ -183,7 +185,8 @@
"notation" : "943",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Geschichte Deutschlands"
}, {
Expand Down
3 changes: 2 additions & 1 deletion src/test/resources/alma-fix/990103899140206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@
"notation" : "310",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Allgemeine Statistiken"
}, {
Expand Down
3 changes: 2 additions & 1 deletion src/test/resources/alma-fix/990104908070206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@
"notation" : "330",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Wirtschaft"
}, {
Expand Down
9 changes: 6 additions & 3 deletions src/test/resources/alma-fix/990108740950206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@
"notation" : "070",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Nachrichtenmedien, Journalismus, Verlagswesen"
}, {
Expand All @@ -139,7 +140,8 @@
"notation" : "630",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Landwirtschaft, Veterinärmedizin"
}, {
Expand All @@ -155,7 +157,8 @@
"notation" : "640",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Hauswirtschaft und Familienleben"
}, {
Expand Down
3 changes: 2 additions & 1 deletion src/test/resources/alma-fix/990108873860206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,8 @@
"notation" : "610",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Medizin, Gesundheit"
}, {
Expand Down
3 changes: 2 additions & 1 deletion src/test/resources/alma-fix/990108874370206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@
"notation" : "390",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Bräuche, Etikette, Folklore"
}, {
Expand Down
3 changes: 2 additions & 1 deletion src/test/resources/alma-fix/990109712970206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,8 @@
"notation" : "780",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Musik allgemein"
}, {
Expand Down
3 changes: 2 additions & 1 deletion src/test/resources/alma-fix/990113537330206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,8 @@
"notation" : "380",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Handel, Kommunikation, Verkehr"
}, {
Expand Down
3 changes: 2 additions & 1 deletion src/test/resources/alma-fix/990119186660206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@
"notation" : "050",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Zeitschriften, fortlaufende Sammelwerke"
}, {
Expand Down
9 changes: 6 additions & 3 deletions src/test/resources/alma-fix/990133067580206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@
"notation" : "010",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Bibliografien"
}, {
Expand All @@ -155,7 +156,8 @@
"notation" : "914.3",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Geografie, Reisen (Deutschland)"
}, {
Expand All @@ -171,7 +173,8 @@
"notation" : "943",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Geschichte Deutschlands"
}, {
Expand Down
6 changes: 4 additions & 2 deletions src/test/resources/alma-fix/990136041660206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@
"notation" : "914.3",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Geografie, Reisen (Deutschland)"
}, {
Expand All @@ -185,7 +186,8 @@
"notation" : "943",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Geschichte Deutschlands"
}, {
Expand Down
3 changes: 2 additions & 1 deletion src/test/resources/alma-fix/990166236770206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@
"notation" : "125",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "125"
}, {
Expand Down
6 changes: 4 additions & 2 deletions src/test/resources/alma-fix/990170546170206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,8 @@
"notation" : "700",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Künste, Bildende Kunst allgemein"
}, {
Expand All @@ -182,7 +183,8 @@
"notation" : "690",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Hausbau, Bauhandwerk"
}, {
Expand Down
3 changes: 2 additions & 1 deletion src/test/resources/alma-fix/990183054020206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@
"notation" : "610",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Medizin, Gesundheit"
}, {
Expand Down
3 changes: 2 additions & 1 deletion src/test/resources/alma-fix/990184127410206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,8 @@
"notation" : "300",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Sozialwissenschaften, Soziologie, Anthropologie"
}, {
Expand Down
3 changes: 2 additions & 1 deletion src/test/resources/alma-fix/990193229450206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,8 @@
"notation" : "900",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Geschichte"
}, {
Expand Down
3 changes: 2 additions & 1 deletion src/test/resources/alma-fix/990196925330206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,8 @@
"notation" : "070",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Nachrichtenmedien, Journalismus, Verlagswesen"
}, {
Expand Down
6 changes: 4 additions & 2 deletions src/test/resources/alma-fix/990213906490206441.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,14 +151,16 @@
"notation" : "830",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Deutsche Literatur"
}, {
"notation" : "B",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Belletristik"
} ],
Expand Down
12 changes: 8 additions & 4 deletions src/test/resources/alma-fix/991005935279706485.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,8 @@
"notation" : "280",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "280"
}, {
Expand All @@ -242,7 +243,8 @@
"notation" : "370",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Erziehung, Schul- und Bildungswesen"
}, {
Expand All @@ -258,7 +260,8 @@
"notation" : "330",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Wirtschaft"
}, {
Expand All @@ -274,7 +277,8 @@
"notation" : "630",
"type" : [ "Concept" ],
"source" : {
"label" : "DDC-Sachgruppen der ZDB"
"label" : "DDC-Sachgruppen der ZDB",
"id" : "https://zeitschriftendatenbank.de/fileadmin/user_upload/ZDB/pdf/zdbformat/5080.pdf"
},
"label" : "Landwirtschaft, Veterinärmedizin"
}, {
Expand Down
Loading
Loading