Drop Docker config from Supervisor backup #5605
Conversation
|
Warning Rate limit exceeded@agners has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 6 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe pull request removes Docker configuration handling from the backup system. Two methods related to storing and restoring Docker registry credentials have been removed from the Changes
Sequence Diagram(s)sequenceDiagram
participant BM as BackupManager
participant B as Backup
BM->>B: Initiate backup creation
Note over BM,B: Docker configuration handling removed
B-->>BM: Return backup data
sequenceDiagram
participant BM as BackupManager
participant B as Backup
BM->>B: Initiate backup restoration
Note over BM,B: Docker configuration restoration step removed
B-->>BM: Return restoration status
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
The Docker config is part of the main backup metadata. Because we consolidate encrypted and unencrypted backups today, this leads to potential bugs when restoring a backup.
agners
force-pushed
the
drop-dockerconfig-from-backup
branch
from
bc08e27 to
0534d67
Compare
There was a problem hiding this comment.
Looks good. Two other small things we should probably remove though:
supervisor/supervisor/backups/const.py
Line 27 in 129a37a
supervisor/supervisor/backups/const.py
Line 42 in 129a37a
Proposed change
The Docker config is part of the main backup metadata. It allows to setup repository specific authentication information (e.g. to use a login for Docker Hub credentials for
hub.docker.comcan be entered). The password for these login information gets encrypted. Because we consolidate encrypted and unencrypted backups today on Supervisor side, we end up with only one of the two metadata in the cache.We could implement a fix by storing this particular metadata per location. However, this adds complexity and code for a feature which is not much used.
Instead, we should move to a Supervisor specific inner tar (
supervisor.tar[.gz]).Type of change
Additional information
Checklist
ruff format supervisor tests)If API endpoints or add-on configuration are added/changed:
Summary by CodeRabbit