Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows+macOS CI by updating to Python 3.11. #19029

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Fix Windows+macOS CI by updating to Python 3.11. #19029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ba4f11
Bump Python version in macos and windows CI builds to 3.11.
ScottTodd Nov 5, 2024
01d78cb
Fix mnist_builder_test path checking on Windows.
ScottTodd Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci_macos_x64_clang.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- name: "Setting up Python"
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.1.0
with:
python-version: "3.10"
python-version: "3.11"
cache: "pip"
- name: "Installing Python packages"
run: pip install -r runtime/bindings/python/iree/runtime/build_requirements.txt
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci_windows_x64_msvc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: "Setting up Python"
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.1.0
with:
python-version: "3.10" # Needs pybind >= 2.10.1 for Python >= 3.11
python-version: "3.11"
- name: "Installing Python packages"
run: |
python3 -m venv .venv
Expand Down
2 changes: 1 addition & 1 deletion compiler/bindings/python/test/build_api/mnist_builder_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ def testBuildNonDefaultSubTarget(self):
mod, args=["mnist/mnist.mlir"] + DEFAULT_TARGET_ARGS, stdout=out_file
)
output = out_file.getvalue().strip()
self.assertIn("genfiles/mnist/mnist.mlir", output)
output_path = Path(output)
self.assertIn("genfiles/mnist/mnist.mlir", output_path.as_posix())
contents = output_path.read_text()
self.assertIn("module", contents)

Expand Down
Loading