-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows+macOS CI by updating to Python 3.11. #19029
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer publish Python wheels for these platforms earlier than 3.11.
marbre
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Scott!
macOS build passed. Windows build is still pending but looks good so far. I'll wait for it to complete before merging. |
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
Pending CI builds (since these are nightly / on-demand and take hours): * Windows: https://github.com/iree-org/iree/actions/runs/11689195978 * macOS: https://github.com/iree-org/iree/actions/runs/11689197108 The new `iree.build` package depends on Python 3.11: iree-org#18630 (comment). We currently publish Python packages for 3.9+ on Linux but only 3.11+ on macOS and Windows: * https://github.com/iree-org/iree/blob/9650bfe441d5f8ce4a16395ee6b3ad43968caa2e/build_tools/python_deploy/build_linux_packages.sh#L68 * https://github.com/iree-org/iree/blob/9650bfe441d5f8ce4a16395ee6b3ad43968caa2e/.github/workflows/build_package.yml#L259-L266 * https://github.com/iree-org/iree/blob/9650bfe441d5f8ce4a16395ee6b3ad43968caa2e/.github/workflows/build_package.yml#L247-L254 We can relax the 3.11 dependency in the package, but we might as well update these workflows to test with the version that we distribute packages for.
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
Pending CI builds (since these are nightly / on-demand and take hours): * Windows: https://github.com/iree-org/iree/actions/runs/11689195978 * macOS: https://github.com/iree-org/iree/actions/runs/11689197108 The new `iree.build` package depends on Python 3.11: iree-org#18630 (comment). We currently publish Python packages for 3.9+ on Linux but only 3.11+ on macOS and Windows: * https://github.com/iree-org/iree/blob/9650bfe441d5f8ce4a16395ee6b3ad43968caa2e/build_tools/python_deploy/build_linux_packages.sh#L68 * https://github.com/iree-org/iree/blob/9650bfe441d5f8ce4a16395ee6b3ad43968caa2e/.github/workflows/build_package.yml#L259-L266 * https://github.com/iree-org/iree/blob/9650bfe441d5f8ce4a16395ee6b3ad43968caa2e/.github/workflows/build_package.yml#L247-L254 We can relax the 3.11 dependency in the package, but we might as well update these workflows to test with the version that we distribute packages for. Signed-off-by: Giacomo Serafini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
infrastructure
Relating to build systems, CI, or testing
platform/macos 🍎
MacOS-specific build, execution, benchmarking, and deployment
platform/windows 🚪
Windows-specific build, execution, benchmarking, and deployment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending CI builds (since these are nightly / on-demand and take hours):
The new
iree.build
package depends on Python 3.11: #18630 (comment). We currently publish Python packages for 3.9+ on Linux but only 3.11+ on macOS and Windows:iree/build_tools/python_deploy/build_linux_packages.sh
Line 68 in 9650bfe
iree/.github/workflows/build_package.yml
Lines 259 to 266 in 9650bfe
iree/.github/workflows/build_package.yml
Lines 247 to 254 in 9650bfe
We can relax the 3.11 dependency in the package, but we might as well update these workflows to test with the version that we distribute packages for.