Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows+macOS CI by updating to Python 3.11. #19029

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

ScottTodd
Copy link
Member

Pending CI builds (since these are nightly / on-demand and take hours):

The new iree.build package depends on Python 3.11: #18630 (comment). We currently publish Python packages for 3.9+ on Linux but only 3.11+ on macOS and Windows:

  • python_versions="${override_python_versions:-cp39-cp39 cp310-cp310 cp311-cp311 cp312-cp312 cp313-cp313 cp313-cp313t}"
  • - name: Build compiler wheels (Windows)
    if: "matrix.build-package == 'py-compiler-pkg' && matrix.build-family == 'windows'"
    shell: powershell
    env:
    package_suffix: ${{ github.event.inputs.package_suffix }}
    packages: "iree-compiler"
    output_dir: "${{ github.workspace }}/bindist"
    override_python_versions: "3.11 3.12 3.13"
  • - name: Build compiler wheels (MacOS)
    if: "matrix.build-package == 'py-compiler-pkg' && matrix.build-family == 'macos'"
    shell: bash
    env:
    package_suffix: ${{ github.event.inputs.package_suffix }}
    packages: "iree-compiler"
    output_dir: "${{ github.workspace }}/bindist"
    override_python_versions: "3.11 3.12 3.13"

We can relax the 3.11 dependency in the package, but we might as well update these workflows to test with the version that we distribute packages for.

@ScottTodd ScottTodd added infrastructure Relating to build systems, CI, or testing platform/windows 🚪 Windows-specific build, execution, benchmarking, and deployment platform/macos 🍎 MacOS-specific build, execution, benchmarking, and deployment labels Nov 5, 2024
@ScottTodd ScottTodd marked this pull request as ready for review November 5, 2024 21:58
Copy link
Member

@marbre marbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Scott!

@ScottTodd
Copy link
Member Author

macOS build passed.

Windows build is still pending but looks good so far. I'll wait for it to complete before merging.

@ScottTodd ScottTodd merged commit fb936a9 into main Nov 5, 2024
41 checks passed
@ScottTodd ScottTodd deleted the users/scotttodd/ci-fixes branch November 5, 2024 22:40
Groverkss pushed a commit to Groverkss/iree that referenced this pull request Dec 1, 2024
Pending CI builds (since these are nightly / on-demand and take hours):
* Windows: https://github.com/iree-org/iree/actions/runs/11689195978
* macOS: https://github.com/iree-org/iree/actions/runs/11689197108

The new `iree.build` package depends on Python 3.11:
iree-org#18630 (comment). We
currently publish Python packages for 3.9+ on Linux but only 3.11+ on
macOS and Windows:
*
https://github.com/iree-org/iree/blob/9650bfe441d5f8ce4a16395ee6b3ad43968caa2e/build_tools/python_deploy/build_linux_packages.sh#L68
*
https://github.com/iree-org/iree/blob/9650bfe441d5f8ce4a16395ee6b3ad43968caa2e/.github/workflows/build_package.yml#L259-L266
*
https://github.com/iree-org/iree/blob/9650bfe441d5f8ce4a16395ee6b3ad43968caa2e/.github/workflows/build_package.yml#L247-L254

We can relax the 3.11 dependency in the package, but we might as well
update these workflows to test with the version that we distribute
packages for.
giacs-epic pushed a commit to giacs-epic/iree that referenced this pull request Dec 4, 2024
Pending CI builds (since these are nightly / on-demand and take hours):
* Windows: https://github.com/iree-org/iree/actions/runs/11689195978
* macOS: https://github.com/iree-org/iree/actions/runs/11689197108

The new `iree.build` package depends on Python 3.11:
iree-org#18630 (comment). We
currently publish Python packages for 3.9+ on Linux but only 3.11+ on
macOS and Windows:
*
https://github.com/iree-org/iree/blob/9650bfe441d5f8ce4a16395ee6b3ad43968caa2e/build_tools/python_deploy/build_linux_packages.sh#L68
*
https://github.com/iree-org/iree/blob/9650bfe441d5f8ce4a16395ee6b3ad43968caa2e/.github/workflows/build_package.yml#L259-L266
*
https://github.com/iree-org/iree/blob/9650bfe441d5f8ce4a16395ee6b3ad43968caa2e/.github/workflows/build_package.yml#L247-L254

We can relax the 3.11 dependency in the package, but we might as well
update these workflows to test with the version that we distribute
packages for.

Signed-off-by: Giacomo Serafini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Relating to build systems, CI, or testing platform/macos 🍎 MacOS-specific build, execution, benchmarking, and deployment platform/windows 🚪 Windows-specific build, execution, benchmarking, and deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants