Share workflow failure alerting between ci.yml and pkgci.yml. #19444
+103
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit babe0c3.
marbre
reviewed
Dec 10, 2024
This was referenced Dec 10, 2024
amd-chrissosa
approved these changes
Dec 11, 2024
marbre
approved these changes
Dec 11, 2024
ScottTodd
added a commit
that referenced
this pull request
Dec 19, 2024
…9445) ## History These workflow jobs were originally part of `ci.yml` but they were moved out of part of #17957. ## Reasons to keep them separate * Run history for each workflow is independent, e.g. https://github.com/iree-org/iree/actions/workflows/ci_linux_x64_clang.yml and https://github.com/iree-org/iree/actions/workflows/ci_windows_x64_msvc.yml. * Performance metrics for each workflow are independent:  * Status badges are independent ## Reasons to merge them back * Less code duplication, particularly for `setup` and `summary` steps (see #19444) * Less noise in the checks view in pull requests (note all the `setup` jobs, and the PR above will add similarly dupliated `summary` jobs):  * Centralized logs for checks, not split between multiple pages like they are currently: Current | With this PR -- | --  |  * This gives us a single `ci_summary` check in `ci.yml` to set as a required check instead of multiple split across workflows * Given enough runner capacity / budget, we could run all these jobs on presubmit/postsubmit and not just on nightly schedules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #9305.
Changes included:
ci.ymlinto a new reusable workflow in theworkflow_summary.ymlfile.pkgci.yml.summarystep toci_summaryandpkgci_summaryto disambiguate "required checks". You'd think GitHub would use keys that aren't ambiguous for required checks but nooooope: