-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: main exp workflow (run,show,diff,apply) #2200
Conversation
"source": "exp/index.md", | ||
"children": [ | ||
{ | ||
"label": "exp run", | ||
"slug": "run" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hiii @rogermparent another quick callout... Would it be possible to automatically label subcommands inside children
as parent children
to avoid all these {}
structures (here and in other subcommand groups). Ty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like replacing { "label": "exp run", "slug": "run" }
with the string "run"
having the same effect? That's a good idea, and totally doable!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I was just thinking to replace the whole Yep, exactly (:{}
block with "run"
in this case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any hope we can get that done for this PR @rogermparent? No worries if not but let's make make an issue then? Thanks
and reorder exp run options
59412a9
to
a16d83e
Compare
LGTM @shcheklein @dberenbaum @pmrowla ? Examples will be coming in a separate PR (this one is large enough). The remaining commands also have their own PR (#2243). |
78b376e
to
0fb378c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
OK guys I'm going to merge this. There will be more iterations in case anyone has more comments. Thanks! |
exp run/show/diff/apply
Descs and OptionsI left out the examples in this PR b/c it's getting too big.