-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to pac4j 6.x and migrate to EE 9 #455
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #455 +/- ##
============================================
+ Coverage 71.73% 72.19% +0.45%
- Complexity 222 224 +2
============================================
Files 17 17
Lines 1033 1050 +17
Branches 148 148
============================================
+ Hits 741 758 +17
Misses 201 201
Partials 91 91 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got a WIP branch with this same effort (except on the jdk-17 stuff), but I didn't have the bandwidth to complete it
Duplicated by #491 |
@michael-doubez Closing a PR with a passing CI build in favor of one with a failing CI build? |
It does not, as the relevant code is no longer part of this PR.
Thanks, @pankajy-dev! Since the changes look good, is it appropriate for you to approve the PR? |
@fcojfernandez Any update on reviewing this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the use of API plugins for things that we do not consume as plugins seems incorrect.
I cannot review but the code looks good as far as I can tell - Looking forward for the release 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, a little concerned at the switch to the use of a Jenkins plugin though. #455 (comment)
Co-authored-by: Francisco Javier Fernandez <[email protected]>
Passes
mvn clean verify
and ATH'splugins.OicAuthPluginTest
, but I am not very familiar with this plugin so I do not know if there is additional work that needs to be done. I am not planning on working on this PR any further, so please treat this PR as a starting point if and when it is desirable to complete this migration.Testing done
mvn clean verify
plugins.OicAuthpluginTest