JetPack Compose #42
Draft
JetPack Compose #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… making the component private. https://mrmans0n.github.io/compose-rules/rules/#when-should-i-expose-modifier-parameters. Remove commented out code too.
…dle-license-plugin." This reverts commit f038f55.
…ge if beyondBoundsPageCount set to 2 not 0.
…with left-right swiping component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the app to Jetpack Compose.
This PR changes the whole UI to Jetpack Compose and material 3 visual design, avoiding a migration later, having to make new Jetpack Compose code use material 2 or the old View/Fragment implementation use material 3.
Had to replace the licence screen implementation to move it to material 3, due to google/play-services-plugins#248.
https://stackoverflow.com/questions/76852715/how-to-use-open-source-notices-library-with-jetpack-compose lists some options.
Initially, tried using https://github.com/jaredsburrows/gradle-license-plugin. It provides tasks to generate html, but they aren't run automatically when build. The
./gradlewtasks breaks withAndroidSourceSet with name 'developDebugAndroidTest' not founderror, making it a pain to add dependencies, so I gave up with this library.Used https://github.com/mikepenz/AboutLibraries, which worked on first attempt.