Do not blindly lowercase language names #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than that, only do that if they are completely uppercased (which is probably the cause of a \MakeUppercase e.g. in headings) This assures miced-case names such as USenglish are treated correctly Fixes issue #12.
|
Thanks for the feedback. I thought the braces would group the second token in the test and my tests seem to have acknowledged that, but I stand corrected. I figure that the following would work, right? But your last sentence indicates that you do not like the solution at all. Alas, I don't have a better idea, it's as general as it gets. |
Improve Czech language support.
Add Latvian support
Add support for Polish language
added estonian quotes
... or lack thereof.
added ukrainian quotes
Use polygossia's new babel-equivalent language name interface. Only works with polyglossia 1.45 (2019/20/27) or above, but the code is fully backwards compatible with older versions (variant detection will fail then). See also #4.
Improve polyglossia interface
\languagename may not always be available, so we better test for it. Furthermore, \languagename and \babelname should not be expanded for the \ifx test.
Fix \languagename issue
\langname does not exist. Fixes #30.
Fix \languagename typo
Set up rudimentary tests
Expand \csq@mainlang (#35)
|
This PR seems screwed. I'll open a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than that, only do that if they are completely uppercased
(which is probably the cause of a \MakeUppercase e.g. in headings)
This assures miced-case names such as USenglish are treated correctly
Fixes issue #12.