Add Extra --no-sandbox #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding --no-sandbox option in def getChromeVersion(self) needed to run in docker headless.
Reviewer's Guide by SourceryThis pull request adds the --no-sandbox option to the ChromeOptions in the getChromeVersion method to ensure that Chrome can run in a Docker headless environment without crashing. This change has been confirmed to not affect normal operation on Windows. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @jdeath - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -200,7 +200,7 @@ def getCCodeLang(self, lang: str, geo: str) -> tuple: | |||
| def getChromeVersion(self) -> str: | |||
| chrome_options = ChromeOptions() | |||
| chrome_options.add_argument("--headless=new") | |||
|
|
|||
| chrome_options.add_argument("--no-sandbox") | |||
There was a problem hiding this comment.
🚨 issue (security): Consider potential security implications of --no-sandbox.
The --no-sandbox flag can pose security risks as it disables the Chrome sandbox, which is a key security feature. Ensure that this change is necessary and that appropriate security measures are in place.
klept0
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding --no-sandbox option in def getChromeVersion(self) needed to run in docker headless. Get
Confirmed did not affect running normally in Windows.
Without switch, get following error:
selenium.common.exceptions.SessionNotCreatedException: Message: session not created: Chrome failed to start: exited normally. (session not created: DevToolsActivePort file doesn't exist) (The process started from chrome location /usr/bin/google-chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)Summary by Sourcery
Added the --no-sandbox option to the Chrome WebDriver configuration in the getChromeVersion method to ensure compatibility with Docker headless environments.