Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Extra --no-sandbox #123

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Add Extra --no-sandbox #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def getCCodeLang(self, lang: str, geo: str) -> tuple:
def getChromeVersion(self) -> str:
chrome_options = ChromeOptions()
chrome_options.add_argument("--headless=new")

chrome_options.add_argument("--no-sandbox")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 issue (security): Consider potential security implications of --no-sandbox.

The --no-sandbox flag can pose security risks as it disables the Chrome sandbox, which is a key security feature. Ensure that this change is necessary and that appropriate security measures are in place.

driver = WebDriver(options=chrome_options)
version = driver.capabilities["browserVersion"]

Expand Down
Loading