-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node.legacyXFS parameter to fix XFS on nodes with kernel version ≤ 5.4 #2121
Conversation
Skipping CI for Draft Pull Request. |
b441150
to
ec11ff6
Compare
ec11ff6
to
ec9732b
Compare
/hold Will test on linux 5.4 today. But still ready for review. |
ec9732b
to
75a694e
Compare
/unhold Customer tested with their custom AMI, driver was functional. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm other than Elijah's one comment. Assuming that is addressed (and no further issues are reported in review), I plan to mark this PR as approved (if nobody else does so first) the evening of Tuesday 9/10.
75a694e
to
eeb919a
Compare
eeb919a
to
a3da5fd
Compare
/lgtm |
/lgtm thank you ! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
Feature
What is this PR about? / Why do we need it?
Adds workaround for customers using XFS on nodes with linux kernel version ≤ 5.4.
Warning: This option will be removed in a future release. It is a temporary workaround for users unable to immediately migrate off of older kernel versions.
Adds
legacy-xfs
node driver option and andnode.legacyXFS
helm chart parameter which formats XFS volumes withbigtime=0,inobtcount=0,reflink=0
, so that they can be mounted onto nodes with linux kernel ≤ 5.4. Volumes formatted with this option may experience issues after 2038, and will be unable to use some XFS features (for example, reflinks).What testing is done?
Created node with Linux ≤ v5.4, attempted to run stateful pod with and without
legacy-xfs
parameter. Volume only mounted when legacy-xfs=true.