Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move modules mount to all dind jobs now that we modprobe ipv6 #32895

Merged
merged 1 commit into from
Jul 2, 2024
Merged

move modules mount to all dind jobs now that we modprobe ipv6 #32895

merged 1 commit into from
Jul 2, 2024

Conversation

BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Jul 2, 2024 •
edited
Loading

rollforward instead of #32894

currently we hit:

wrapper.sh] [SETUP] Docker in Docker enabled, initializing ...
net.ipv6.conf.all.disable_ipv6 = 0
net.ipv6.conf.all.forwarding = 1
modprobe: FATAL: Module ip6table_nat not found in directory /lib/modules/5.15.0-1054-gke

in jobs with the dind preset, but not the kind preset, so we lift this to dind everywhere

longer term, will refactor this out entirely

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2024
BenTheElder
BenTheElder commented Jul 2, 2024
View reviewed changes
config/prow/config.yaml
# TODO: move this out of being done in the jobs
- mountPath: /lib/modules
name: modules
readOnly: true
# volume mounts for kind
- labels:
preset-kind-volume-mounts: "true"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this AND the preset-dind-enabled are currently applied to all kind jobs

so we can move the mount over to the dind mounts, and ensure all dind jobs can modprobe

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 2, 2024
@BenTheElder
Copy link
Member Author

follow-up to #32890

@BenTheElder BenTheElder mentioned this pull request Jul 2, 2024
Closed
@cblecker
Copy link
Member

cblecker commented Jul 2, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8b8b374 into kubernetes:master Jul 2, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key config.yaml using file config/prow/config.yaml

In response to this:

rollforward instead of #32894

currently we hit:

wrapper.sh] [SETUP] Docker in Docker enabled, initializing ...
net.ipv6.conf.all.disable_ipv6 = 0
net.ipv6.conf.all.forwarding = 1
modprobe: FATAL: Module ip6table_nat not found in directory /lib/modules/5.15.0-1054-gke

in jobs with the dind preset, but not the kind preset, so we lift this to dind everywhere

longer term, will refactor this out entirely

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BenTheElder BenTheElder deleted the roll-fw branch July 2, 2024 23:10
@BenTheElder
Copy link
Member Author

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kind/648/pull-kind-verify/1808277233349955584

That's better

This was referenced Jul 2, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@MadhavJivrajani MadhavJivrajani Awaiting requested review from MadhavJivrajani

@Priyankasaggu11929 Priyankasaggu11929 Awaiting requested review from Priyankasaggu11929

Assignees

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @k8s-ci-robot @cblecker