Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move modules mount to all dind jobs now that we modprobe ipv6 #32895

Merged
merged 1 commit into from
Jul 2, 2024
+9 −7
Merged

move modules mount to all dind jobs now that we modprobe ipv6 #32895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions config/prow/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -999,25 +999,27 @@ presets:
# krte (normal) path
- name: docker-root
emptyDir: {}
# we need to modprobe ipv6 iptables
# TODO: move this out of being done in the jobs
- name: modules
hostPath:
path: /lib/modules
type: Directory
volumeMounts:
- name: docker-graph
mountPath: /docker-graph
- name: docker-root
mountPath: /var/lib/docker
- mountPath: /lib/modules
name: modules
readOnly: true
# volume mounts for kind
- labels:
preset-kind-volume-mounts: "true"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this AND the preset-dind-enabled are currently applied to all kind jobs

so we can move the mount over to the dind mounts, and ensure all dind jobs can modprobe

volumeMounts:
- mountPath: /lib/modules
name: modules
readOnly: true
- mountPath: /sys/fs/cgroup
name: cgroup
volumes:
- name: modules
hostPath:
path: /lib/modules
type: Directory
- name: cgroup
hostPath:
path: /sys/fs/cgroup
Expand Down