Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take Ethernet PHY out of reset so default clock is 125 Mhz #77

Merged
merged 2 commits into from
May 26, 2020

Conversation

skiphansen
Copy link
Contributor

Without this change the terminal baud rate is 23,941 (measured by a scope) since the default clock is 25 Mhz instead of the expected 125 Mhz.

The master clock on the Pano comes from the Ethernet PHY which is normally 125Mhz, but it is 25 Mhz while the PHY is in reset. The active low reset pin is driven by FPGA pin R11.

See https://github.com/tomverbeure/panologic-g2#fpga-external-clocking-architecture

@@ -97,6 +97,9 @@
Subsignal("cke", Pins("D2"), IOStandard("SSTL18_II")),
Subsignal("odt", Pins("J6"), IOStandard("SSTL18_II")),
),
# Ethernet phy reset (clk125 is 25 Mhz instead of 125 Mhz if reset is active)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a link to the documentation about this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@enjoy-digital enjoy-digital merged commit 935a711 into litex-hub:master May 26, 2020
@enjoy-digital
Copy link
Member

Thanks! You were probably the first to test the target since i just prepared it and was planning to test it in the next days.

@skiphansen
Copy link
Contributor Author

Thanks Florent!

When you get around to the Pano perhaps you can add DDR support? I'm struggling with timvideos/litex-buildenv#444, I'm trying to merge DDR support from into litex-boards to see if the problem has been fixed recently, but I'm in way over my head with DDR.

@enjoy-digital
Copy link
Member

@skiphansen: the current target is minimal because i wanted to work on that and refactor/simplify the S6DDRPHY at the same time (enjoy-digital/litedram#182). I should be able to work on it in the next days (but i'm not sure which revision of the board i have, i'll have to check).

@skiphansen
Copy link
Contributor Author

@enjoy-digital: Great, if you don't have a Rev C (or Rev B) I'd be more than happy to help you test, just let me know.

@enjoy-digital
Copy link
Member

@skiphansen: i just did a test on hardware and i have a Rev C, so i should be able to help you getting the DDR working on Rev C.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants