-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add models option in discover cli command to generate spec… #8612
feat(cli): add models option in discover cli command to generate spec… #8612
Conversation
Pull Request Test Coverage Report for Build 2340528877
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM 👍
Please rebase and resolve the merge conflict.
e71d001
to
cae645a
Compare
@achrinza done. please review |
Please fix failing test. |
…ific models Signed-off-by: Awais Saeed <[email protected]>
cae645a
to
f302387
Compare
@achrinza: may we please ask you to having a quick look at this PR? there is an error in the build, but no error message available. Thanks for the clarification... |
@achrinza |
There hasn't been any progress from the PR creator. Can I recreate the PR referencing this PR to have this PR move forward? Or the PR can be merged without their response? @achrinza |
Closing in favor of #9092 |
Pull Request Test Coverage Report for Build 2340528877Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
added --models option inside lb4 discover the command to generate specific models
Fixes #7104
Checklist
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated👉 Check out how to submit a PR 👈