Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add models option in discover cli command to generate spec… #8612

Conversation

sohaibahsan007
Copy link
Contributor

@sohaibahsan007 sohaibahsan007 commented May 17, 2022

added --models option inside lb4 discover the command to generate specific models

Fixes #7104

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2340528877

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 76.515%

Totals Coverage Status
Change from base Build 2340239535: 0.007%
Covered Lines: 18022
Relevant Lines: 19119

💛 - Coveralls

@achrinza achrinza self-requested a review May 20, 2022 19:15
Copy link
Member

@achrinza achrinza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 👍

Please rebase and resolve the merge conflict.

@awaissaeedforenax awaissaeedforenax force-pushed the discover-models-option branch 2 times, most recently from e71d001 to cae645a Compare May 20, 2022 19:31
@sohaibahsan007
Copy link
Contributor Author

@achrinza done. please review

@achrinza
Copy link
Member

Please fix failing test.

@awaissaeedforenax awaissaeedforenax force-pushed the discover-models-option branch from cae645a to f302387 Compare May 23, 2022 12:24
@cloud20x
Copy link

@achrinza: may we please ask you to having a quick look at this PR? there is an error in the build, but no error message available. Thanks for the clarification...

@cloud20x
Copy link

cloud20x commented Nov 7, 2022

@achrinza
May I please ask you to get back to our question?
And please add:
[email protected]
to this PR so he can take it forward?
Thanks

@aaqilniz
Copy link
Contributor

There hasn't been any progress from the PR creator. Can I recreate the PR referencing this PR to have this PR move forward? Or the PR can be merged without their response? @achrinza

@dhmlau
Copy link
Member

dhmlau commented Mar 9, 2023

Closing in favor of #9092

@dhmlau dhmlau closed this Mar 9, 2023
@coveralls
Copy link

coveralls commented Oct 23, 2024

Pull Request Test Coverage Report for Build 2340528877

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 76.83%

Files with Coverage Reduction New Missed Lines %
packages/cli/generators/discover/index.js 1 70.71%
Totals Coverage Status
Change from base Build 2340239535: 0.3%
Covered Lines: 17993
Relevant Lines: 18944

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --tables/--models arguments to lb4 discover command
7 participants