Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): specify models with --models in lb4 discover #9092

Merged
merged 1 commit into from
Feb 26, 2023

Conversation

aaqilniz
Copy link
Contributor

This PR adds an option to lb4 discover command. --models is an option to pass models that lb4 discover should create without prompt.

The actual PR is here. This PR is a copy of the same PR. The reason to create another PR is to move things forward and allow merging the changes to the master. The original PR has been active for a while from the PR creator.

Actual credit for the changes goes to the original PR creator.

Signed-off-by: Muhammad Aaqil [email protected]

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@coveralls
Copy link

coveralls commented Nov 16, 2022

Pull Request Test Coverage Report for Build 3771711042

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 55.258%

Totals Coverage Status
Change from base Build 3765174380: 0.2%
Covered Lines: 9518
Relevant Lines: 12282

💛 - Coveralls

@aaqilniz
Copy link
Contributor Author

@achrinza the linked PR has a failed test and the creator haven't replied to your request to fix the test.

This PR has all the checks clear. Let me know if this PR can be merged or the original PR can be merged.

Thanks.

@achrinza
Copy link
Member

Could we add a Co-authored-by: to the Git commit footer, right above the DCO sign-off, as well?

The format is similar to the DCO sign-off (i.e The original Git author name and email can be copied over as-is).

The final Git commit footer would look something like this:

Co-authored-by: Git Author Name <Git Author Email>
Signed-off-by: Git Author Name <Git Author Email>

@aaqilniz aaqilniz force-pushed the feat/discover-model-options branch from ab1b0f7 to 371bb96 Compare November 18, 2022 15:45
@aaqilniz
Copy link
Contributor Author

aaqilniz commented Dec 4, 2022

Hi @achrinza. I've added the co-authored-by to the git commit footer.
Is this PR good to be merged?

@aaqilniz aaqilniz force-pushed the feat/discover-model-options branch from 371bb96 to e3e3660 Compare December 24, 2022 14:20
@aaqilniz
Copy link
Contributor Author

@achrinza Can you please have a look at the PR?

@aaqilniz
Copy link
Contributor Author

aaqilniz commented Jan 8, 2023

Hi @achrinza. All of the tests have passed with this PR & I have added the co-author tag. Can we get this PR merged?

@aaqilniz
Copy link
Contributor Author

Hi @achrinza. Can you have a look at this PR once again and get it merged if everything is good?

Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaqilniz, thanks for your contribution. Your changes LGTM. I just have a minor comment in the docs.

docs/site/Discovering-models.md Outdated Show resolved Hide resolved
This PR adds an option to lb4 discover command. --models is an option to pass models that lb4
discover should create without prompt.

Co-authored-by: Sohaib Ahsan <[email protected]>
Signed-off-by: Muhammad Aaqil <[email protected]>
@aaqilniz aaqilniz force-pushed the feat/discover-model-options branch from e3e3660 to 9daae2a Compare February 25, 2023 18:11
@aaqilniz
Copy link
Contributor Author

@dhmlau. I just updated the docs. Please have a look.

@dhmlau dhmlau merged commit 4f5f9cc into loopbackio:master Feb 26, 2023
@dhmlau
Copy link
Member

dhmlau commented Feb 26, 2023

@aaqilniz, thanks again for your contribution. Your PR has been merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants