-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): specify models with --models in lb4 discover #9092
feat(cli): specify models with --models in lb4 discover #9092
Conversation
Pull Request Test Coverage Report for Build 3771711042Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@achrinza the linked PR has a failed test and the creator haven't replied to your request to fix the test. This PR has all the checks clear. Let me know if this PR can be merged or the original PR can be merged. Thanks. |
Could we add a The format is similar to the DCO sign-off (i.e The original Git author name and email can be copied over as-is). The final Git commit footer would look something like this:
|
ab1b0f7
to
371bb96
Compare
Hi @achrinza. I've added the |
371bb96
to
e3e3660
Compare
@achrinza Can you please have a look at the PR? |
Hi @achrinza. All of the tests have passed with this PR & I have added the co-author tag. Can we get this PR merged? |
Hi @achrinza. Can you have a look at this PR once again and get it merged if everything is good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aaqilniz, thanks for your contribution. Your changes LGTM. I just have a minor comment in the docs.
This PR adds an option to lb4 discover command. --models is an option to pass models that lb4 discover should create without prompt. Co-authored-by: Sohaib Ahsan <[email protected]> Signed-off-by: Muhammad Aaqil <[email protected]>
e3e3660
to
9daae2a
Compare
@dhmlau. I just updated the docs. Please have a look. |
@aaqilniz, thanks again for your contribution. Your PR has been merged! 🎉 |
This PR adds an option to lb4 discover command. --models is an option to pass models that lb4 discover should create without prompt.
The actual PR is here. This PR is a copy of the same PR. The reason to create another PR is to move things forward and allow merging the changes to the master. The original PR has been active for a while from the PR creator.
Actual credit for the changes goes to the original PR creator.
Signed-off-by: Muhammad Aaqil [email protected]
Checklist
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated