replace getJSON with pure XHR/JSON.parse implementation #45
Conversation
There was a problem hiding this comment.
Thanks so much for the contribution!
This is something I've wanted to do for a while so thanks for getting the ball rolling. Just a few minor comments, but overall looks great. I'm still waiting on my Windows vm to download so I can test in older versions of IE.
leaflet-iiif.js
Outdated
| onsuccess(data); | ||
| }; | ||
|
|
||
| var onprocess = function(){ |
| catch (e){ | ||
|
|
||
| console.log("Failed to parse JSON, because " + e); | ||
| console.log(raw); |
There was a problem hiding this comment.
Looks like there is a mix of tabs and four spaces. Mind converting over to two spaces?
|
I'll sort the spaces out shortly. The next couple days are a bit nutty. |
|
Popping this here for reference too. Not sure but we could include this plugin instead? https://github.com/calvinmetcalf/leaflet-ajax |
|
Well, it's your party so you should do whatever feels right :D Looking over the code with sloppy eyes it's not clear what it gets you – the I guess the larger issue is whether or not you want external dependencies for the iiif-leaflet plugin. If you do (or don't mind having them) then there are worse things that letting jQuery take care of the details for you. |
|
Closing this now in favor of #77 . |
I tried to replace the remaining jQuery dependencies but got lost in a twisty maze of Leaflet expectations.
The other issue is that this PR may not address older versions of IE, maybe?