Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jquery dependency #77

Merged
merged 7 commits into from
Nov 11, 2019
Merged

Remove jquery dependency #77

merged 7 commits into from
Nov 11, 2019

Conversation

mejackreed
Copy link
Owner

In the spirit of #45 from @thisisaaronland .

@2SC1815J what do you think about using native fetch and Promise ?

@thisisaaronland
Copy link

FWIW, I just tried this with Leaflet 1.5.1 and this example and everything seems to work fine:

https://go-iiif.github.io/go-iiif/

@abrin
Copy link
Contributor

abrin commented Oct 21, 2019

@mejackreed this looks nice and clear. my only question is whether you want to be adding a catch to your promises and logging the errors? If you version this, we can test this in our simple implementation.

@mejackreed
Copy link
Owner Author

That's great feedback @abrin. I'll look into adding that , or feel free to submit a PR to this branch if you have an idea of what you would like to see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants