Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jquery dependency #77

Merged
merged 7 commits into from
Nov 11, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
node_modules/
node_modules/
package-lock.json
yarn.lock
11 changes: 9 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
sudo: false
language: node_js
node_js: 'node'

node_js:
- 'lts/*'

before_script:
- npm install

script:
- npm test
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

A Leaflet plugin for viewing IIIF images. [See the demo](http://mejackreed.github.io/Leaflet-IIIF/examples/example.html)

Requires [Leaflet.js](http://leafletjs.com/) and [jQuery](http://jquery.com/)
Requires [Leaflet.js](http://leafletjs.com/).

Leaflet-IIIF relies on browser support for [Promise](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise) and [Fetch API](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API). If you need to support IE or other browsers without this, please use a polyfill.

**Note on Leaflet Compatibility**

Expand Down
1 change: 0 additions & 1 deletion examples/example.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
<link rel="stylesheet" href="https://unpkg.com/[email protected]/dist/leaflet.css" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" />
<script src="https://unpkg.com/[email protected]/dist/leaflet.js"></script>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js"></script>
<script src="../leaflet-iiif.js"></script>
</head>
<body>
Expand Down
1 change: 0 additions & 1 deletion examples/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
<link rel="stylesheet" href="https://unpkg.com/[email protected]/dist/leaflet.css" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" />
<script src="https://unpkg.com/[email protected]/dist/leaflet.js"></script>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js"></script>
<script src="../leaflet-iiif.js"></script>
</head>
<body>
Expand Down
18 changes: 8 additions & 10 deletions leaflet-iiif.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ L.TileLayer.Iiif = L.TileLayer.extend({
}

options = L.setOptions(this, options);
this._infoDeferred = new $.Deferred();
this._infoPromise = null;
this._infoUrl = url;
this._baseUrl = this._templateUrl();
this._getInfo();
Expand Down Expand Up @@ -63,9 +63,8 @@ L.TileLayer.Iiif = L.TileLayer.extend({
onAdd: function(map) {
var _this = this;

// Wait for deferred to complete
$.when(_this._infoDeferred).done(function() {

// Wait for info.json fetch and parse to complete
Promise.all([_this._infoPromise]).then(function() {
// Store unmutated imageSizes
_this._imageSizesOriginal = _this._imageSizes.slice(0);

Expand Down Expand Up @@ -160,9 +159,11 @@ L.TileLayer.Iiif = L.TileLayer.extend({
_getInfo: function() {
var _this = this;

// Look for a way to do this without jQuery
$.getJSON(_this._infoUrl)
.done(function(data) {
_this._infoPromise = fetch(_this._infoUrl)
.then(function(response) {
return response.json();
})
.then(function(data) {
_this.y = data.height;
_this.x = data.width;

Expand Down Expand Up @@ -225,9 +226,6 @@ L.TileLayer.Iiif = L.TileLayer.extend({

_this._tierSizes = tierSizes;
_this._imageSizes = imageSizes;

// Resolved Deferred to initiate tilelayer load
_this._infoDeferred.resolve();
});
},

Expand Down
5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,10 @@
"devDependencies": {
"http-server": "^0.9.0",
"jasmine": "^2.5",
"jquery": "~> 3.0.0",
"karma": "^1.3",
"karma-chrome-launcher": "^3.1.0",
"karma-jasmine": "^1.0",
"karma-phantomjs-launcher": "^1.0.0",
"leaflet": "^1.0",
"phantomjs-prebuilt": "^2.1.5"
"puppeteer": "^1.20.0"
}
}
4 changes: 1 addition & 3 deletions spec/LTileLayerIiifSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -248,11 +248,9 @@ describe('L.TileLayer.Iiif', function() {

it('with a large tileSize and negative minZoom, ensure that the layer does not persist zoom changes', function(done) {

$.when(iiifLayer._infoDeferred).done( function() {

Promise.all([iiifLayer._infoPromise]).then(function() {
map.removeLayer(iiifLayer);
map.addLayer(iiifLayer);

});

iiifLayer.on('load', function() {
Expand Down
4 changes: 2 additions & 2 deletions spec/karma.conf.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// Karma configuration
// Generated on Wed Mar 16 2016 06:58:00 GMT-0700 (PDT)
process.env.CHROME_BIN = require('puppeteer').executablePath()

module.exports = function(config) {
config.set({
Expand All @@ -16,7 +17,6 @@ module.exports = function(config) {
// list of files / patterns to load in the browser
files: [
'./../node_modules/leaflet/dist/leaflet.js',
'./../node_modules/jquery/dist/jquery.js',
'./../leaflet-iiif.js',
'./**/*.js',
{
Expand Down Expand Up @@ -64,7 +64,7 @@ module.exports = function(config) {

// start these browsers
// available browser launchers: https://npmjs.org/browse/keyword/karma-launcher
browsers: ['PhantomJS'],
browsers: ['ChromeHeadless'],


// Continuous Integration mode
Expand Down
Loading