Skip to content
This repository has been archived by the owner on Jan 27, 2025. It is now read-only.

Array of strings handling not working #82

Closed
TobiasNx opened this issue Dec 1, 2021 · 9 comments · Fixed by #87
Closed

Array of strings handling not working #82

TobiasNx opened this issue Dec 1, 2021 · 9 comments · Fixed by #87
Assignees
Labels
Bug Something isn't working

Comments

@TobiasNx
Copy link
Collaborator

TobiasNx commented Dec 1, 2021

Separated this issue from #80 to create smaller issues.

Fix is not able to operate with array of strings, It cannot create new ones and cannot refrence existing once.

It should be able to refrence a string/value with e.g.: test.$append, test.* See: http://librecat.org/Catmandu/#wildcards
It would operate on them as items. (This could also be true for handling entire objects as items.)

Broken workflow

It works with a subfield: here

It could be that this issue is too connected to #80 then we should close it.

@TobiasNx TobiasNx added the Bug Something isn't working label Dec 1, 2021
fsteeg added a commit that referenced this issue Dec 6, 2021
@fsteeg
Copy link
Member

fsteeg commented Dec 6, 2021

Deployed to test, see your example.

@TobiasNx
Copy link
Collaborator Author

TobiasNx commented Dec 7, 2021

It seems to work with string: +1

But is does not seem to work with array of objects where you add a new object:
here

Should be handled in new ticket.

@TobiasNx TobiasNx assigned fsteeg and unassigned TobiasNx Dec 7, 2021
fsteeg added a commit that referenced this issue Dec 9, 2021
As produced in JsonDecoder and Metafix itself: {1=a,2=b} for [a,b]
@fsteeg
Copy link
Member

fsteeg commented Dec 9, 2021

But is does not seem to work with array of objects where you add a new object

Handled this here / in #87 as it's very related. Deployed to test: issue on prod, fixed on test.

@fsteeg fsteeg assigned TobiasNx and unassigned fsteeg Dec 9, 2021
fsteeg added a commit that referenced this issue Dec 9, 2021
@blackwinter
Copy link
Member

@TobiasNx: Can you assign me when #87 is ready to be merged?

@TobiasNx
Copy link
Collaborator Author

TobiasNx commented Dec 10, 2021

Somehow the playground examples do not work for me right now. Perhaps due to changes in test.

But I also tried it with these tests here with fix build from 82-append with ./gradlew publishToMavenLocal:
https://gitlab.com/oersi/oersi-etl/-/tree/FunctionalReview/data/experimental/appendArrays

Now none of my examples seems to work. Did I do anything wrong?

@TobiasNx TobiasNx assigned fsteeg and unassigned TobiasNx Dec 10, 2021
@fsteeg
Copy link
Member

fsteeg commented Dec 14, 2021

I don't understand, still looks good to me, as linked in #82 (comment):

issue on prod

{
  "arrayOfObjectimals" : [ {
    "name" : "cat"
  }, {
    "name" : "dog"
  }, {
    "name" : "fox"
  }, "duck" ]
}

fixed on test

{
  "arrayOfObjectimals" : [ {
    "name" : "cat"
  }, {
    "name" : "dog"
  }, {
    "name" : "fox"
  }, {
    "name" : "duck"
  } ]
}

@fsteeg fsteeg assigned TobiasNx and unassigned fsteeg Dec 14, 2021
@TobiasNx
Copy link
Collaborator Author

TobiasNx commented Dec 14, 2021

Deployed to test, see your example.

It is this string-specific example, that does not work anymore. It worked when I reviewed it last week.

It outputs:

{
  "arrayOfStringimals" : [ "cat", "dog", "fox", {
    "$append" : "duck"
  } ]
}

Also see these testcases which also encompase copy_field and move_field:
https://github.com/oersi/oersi-etl/blob/96a8260df6262079c1fb88f419d935f4cc8be927/data/experimental/appendArrays

Here as playground example

@fsteeg
Copy link
Member

fsteeg commented Dec 15, 2021

Alright, I think the string cases are now all working: one, two, three.

@fsteeg fsteeg removed their assignment Dec 15, 2021
@TobiasNx
Copy link
Collaborator Author

Looks good now +1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants