-
Notifications
You must be signed in to change notification settings - Fork 2
Fix appending issues #87
Conversation
As produced in JsonDecoder and Metafix itself: {1=a,2=b} for [a,b]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from explicit array marking and still somewhat confusing list semantics (merging), 👍
metafix/src/test/java/org/metafacture/metafix/MetafixRecordTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jens Wille <[email protected]>
Thanks for the review! Addressed your feedback in adb0693. |
Test
Fix string:
Is the test wrong? UPDATE: See also #92. |
No, it does not work yet for (indexed) arrays of objects (only strings). To keep changes small and focused, I'd say we disable the test and work on that in #92. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep changes small and focused, I'd say we disable the test and work on that in #92.
Okay.
Will resolve #82 and #80.