Update travis yml #353
Merged
Update travis yml #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those were added long ago to bypass an kalibro_install issue and are no longer necessary.
This is a workaround long ago but still necessary. Some status information has been added.
They get started just for the acceptance tests. This is supposed to prevent false positives for missing mocks on unit tests. This still uses an unreleased version of kalibro_install which should get replaced after this gets working.
This is the official version that supports starting kalibro just for acceptance tests.
This ensures major distributions compatibility.
The issue rubygems/rubygems#1220 shows the problem when using ruby 2.1.5 in association with rubygems 2.5.1 to build prezento. This is the same fix as we did on kalibro client.
Apparently, the ruby 2.0.0-p598 (CentOS 7 default) breaks with the code we were using. This commit replace it with a different syntax that should be reverted when CentOS 7 updates its ruby.
This is meant to ensure we remember when we commit changes without tests. Also, to be able to run all the tests locally without worrying about that, we make the minimum coverage only required if the environment variable 'CI' is set to true. In practice, this means we only check minimun coverage if we are building the environment on travis. Also remove some default configurations for Rails on Simplecov. Updates CHANGELOG
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include builds using ruby 2.0.0-p598 and 2.1.5, CentOS 7 and Debian 8 default versions respectively.
Remove unnecessary configurations.
Make Travis fail if unit test coverage is below 100%.
This closes #351 and #352