Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: make serialization be part of sync task to support file format change #38946

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Jan 2, 2025

See #38945

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/XXL Denotes a PR that changes 1000+ lines. labels Jan 2, 2025
@sre-ci-robot sre-ci-robot requested review from czs007 and sunby January 2, 2025 09:03
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 2, 2025
Copy link
Contributor

mergify bot commented Jan 2, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 2, 2025

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 65.15679% with 100 lines in your changes missing coverage. Please review.

Project coverage is 81.10%. Comparing base (8165044) to head (d078858).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
internal/flushcommon/syncmgr/pack_writer.go 58.41% 74 Missing and 15 partials ⚠️
internal/flushcommon/syncmgr/storage_serializer.go 57.14% 5 Missing and 1 partial ⚠️
internal/flushcommon/syncmgr/task.go 78.94% 2 Missing and 2 partials ⚠️
internal/flushcommon/syncmgr/meta_writer.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38946      +/-   ##
==========================================
- Coverage   81.13%   81.10%   -0.04%     
==========================================
  Files        1388     1390       +2     
  Lines      196485   196480       -5     
==========================================
- Hits       159427   159362      -65     
- Misses      31462    31508      +46     
- Partials     5596     5610      +14     
Components Coverage Δ
Client 79.53% <ø> (ø)
Core 69.53% <ø> (+<0.01%) ⬆️
Go 83.05% <65.15%> (-0.04%) ⬇️
Files with missing lines Coverage Δ
internal/datanode/importv2/util.go 65.04% <100.00%> (-0.07%) ⬇️
internal/flushcommon/syncmgr/options.go 100.00% <100.00%> (ø)
internal/flushcommon/writebuffer/write_buffer.go 71.45% <100.00%> (-1.72%) ⬇️
internal/storage/data_codec.go 77.82% <100.00%> (+0.02%) ⬆️
pkg/metrics/datanode_metrics.go 100.00% <ø> (ø)
internal/flushcommon/syncmgr/meta_writer.go 79.16% <75.00%> (ø)
internal/flushcommon/syncmgr/task.go 92.92% <78.94%> (+10.55%) ⬆️
internal/flushcommon/syncmgr/storage_serializer.go 48.22% <57.14%> (-13.45%) ⬇️
internal/flushcommon/syncmgr/pack_writer.go 58.41% <58.41%> (ø)

... and 53 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 6, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 6, 2025

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 6, 2025

@tedxu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 6, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 6, 2025

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 6, 2025

@tedxu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@tedxu tedxu force-pushed the enhance/serialize_sync_task branch from 983633c to 948a29f Compare January 6, 2025 07:16
Copy link
Contributor

mergify bot commented Jan 6, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 6, 2025

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 7, 2025

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 7, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 7, 2025

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 7, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 8, 2025

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@tedxu
Copy link
Contributor Author

tedxu commented Jan 8, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 8, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tedxu
Copy link
Contributor Author

tedxu commented Jan 8, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants