Add tinyglobby to product benchmark instead of fdir #466
+25
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, the
fdir
package is not a glob solution. Yes, it can be used as a glob, but it simply usespicomatch
to find matching paths and does not apply any heuristics. This is clearly visible in our benchmarks. Rather, it is a competitor to@nodelib/fs.walk
, notfast-glob
.Secondly, another glob package appeared in the ring, which is based on the
fdir
package. So, great! I'll stay here and observe.I'm simply replacing
fdir
withtinyglobby
.