fix(editor): Open chat when executing agent node in canvas v2 #12617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it behave the same as in v1.
Often the "Credential saved" notification is left floating over other elements that prevent the test from continuing until the notification goes away. This should speed up the e2e tests a tiny wee bit.
n8n-assistant
bot
added
n8n team
alexgrozav
approved these changes
Jan 15, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
cat-518-manually-executing-ai-agent-node-doesnt-open-the-chat-panel
|
| Run status |
|
| Run duration | 04m 51s |
| Commit |
|
| Committer | Tomi Turtiainen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
489
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
tomi
deleted the
cat-518-manually-executing-ai-agent-node-doesnt-open-the-chat-panel
branch
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jan 17, 2025
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To make it behave the same as in v1. And fix
233-AI-switch-to-logs-on-error.cy.tstestsOften the "Credential saved" notification is left floating over other elements
that prevent the test from continuing until the notification goes away. This
should speed up the e2e tests a tiny wee bit.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-518/manually-executing-ai-agent-node-doesnt-open-the-chat-panel
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)